Skip to content

Error Handling and Logging around OVM -> EVM Tx hash map#89

Merged
willmeister merged 2 commits intomasterfrom
more_logging_for_tx_hash_mapping
Apr 17, 2020
Merged

Error Handling and Logging around OVM -> EVM Tx hash map#89
willmeister merged 2 commits intomasterfrom
more_logging_for_tx_hash_mapping

Conversation

@willmeister
Copy link
Copy Markdown

Description

Adding more logging around transaction hash mapping, waiting for conf…irmation, and handling errors

Contributing Agreement

Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

const internalTxHash = await this.getInternalTxHash(ovmTxHash)

log.debug(
`Got internal hash [${internalTxHash}]0 for ovm hash [${ovmTxHash}]`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops remove the "0" :)

internalTxHash: string
): Promise<void> {
log.debug(
`Mapping ovmTxHash: ${ovmTxHash} to internal tx hash: ${internalTxHash}.`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very useful

)

await this.context.provider.sendTransaction(signedTx)
const res = await this.context.provider.sendTransaction(signedTx)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@willmeister willmeister merged commit bcdcd68 into master Apr 17, 2020
@willmeister willmeister deleted the more_logging_for_tx_hash_mapping branch April 17, 2020 01:52
snario pushed a commit that referenced this pull request Apr 14, 2021
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
* Query for delegations needing unbonding sigs

* Add validator submission for unbodning tx

* Add logic for submitting unbonding signatures
blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Nov 27, 2024
…e_list

add allowSgtValue/disallowSgtValue to SGT contract
cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025
Co-authored-by: louis.liu <louis.liu@okg.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants