Skip to content

Fix bad comment in Smock Docs#756

Merged
smartcontracts merged 1 commit intoethereum-optimism:masterfrom
transmissions11:patch-1
May 5, 2021
Merged

Fix bad comment in Smock Docs#756
smartcontracts merged 1 commit intoethereum-optimism:masterfrom
transmissions11:patch-1

Conversation

@transmissions11
Copy link
Copy Markdown
Contributor

Description
This function will not return an array of strings, it will return a string.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 5, 2021

⚠️ No Changeset found

Latest commit: a3d7e5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@transmissions11
Copy link
Copy Markdown
Contributor Author

Question:

Off the top of my head I'm not sure if calling a function that returns a struct with ethers returns an object or array?

If it is an object this comment needs to be updated too.

Screen Shot 2021-05-04 at 5 10 16 PM

@smartcontracts
Copy link
Copy Markdown
Contributor

Calling something that returns a struct does indeed return an array (sort of, it actually returns an array that also has keys, it's weird)

@transmissions11
Copy link
Copy Markdown
Contributor Author

Calling something that returns a struct does indeed return an array (sort of, it actually returns an array that also has keys, it's weird)

Ah right web3 does that as well. Very annoying in some cases.

@smartcontracts smartcontracts merged commit c7d17ca into ethereum-optimism:master May 5, 2021
@transmissions11 transmissions11 deleted the patch-1 branch May 7, 2021 18:11
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
theochap pushed a commit that referenced this pull request Dec 10, 2025
* feat: flush oracle cache on reorg #724

* fix pr review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants