Conversation
🦋 Changeset detectedLatest commit: 48b86e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
requested changes
May 4, 2021
Collaborator
Author
I was able to repro the bug on my own M1 which is where I fixed it, so I think those are both covered now :) |
Contributor
|
Confirmed working on my M1. Didn't even see the address manager bug! |
tynes
approved these changes
May 5, 2021
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
* fix(hh-ovm): hack RUN_SOLCJS back to RUN_SOLC * chore: add changeset
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the long-elusive #675 where builds were failing on M1 macs. There is a better fix for this long-term, but we should merge this in now to unblock M1 users.
Additional context
We barked up the wrong tree on this one for a while because it looked an awful lot like a caching issue, but turned out to be something else: it seems that on M1s, the hardhat
TASK_COMPILE_SOLIDITY_RUN_SOLCdoes not run, probably because it does not see an M1 build, and therefore wantsTASK_COMPILE_SOLIDITY_RUN_SOLCJSto be run directly. The fix here routes this task back toTASK_COMPILE_SOLIDITY_RUN_SOLCon the first pass, becausehh-ovmalready enforces that we run solcjs, and within that task we do the// @unsupported: evm/ovmfiltering.Metadata
kall, causing compilation errors #675