Refactor and simplify token gateway contracts#733
Refactor and simplify token gateway contracts#733
Conversation
🦋 Changeset detectedLatest commit: dadac9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0df7c34 to
6b2f8e5
Compare
rename OVM_L2DepositedERC20 to OVM_L2TokenGateway refactor OVM_ETH to continue being its own gateway refactor(contracts): rename 'DepositedToken' to 'TokenGateway'
6b2f8e5 to
eea2140
Compare
There was a problem hiding this comment.
I liked this more generic naming.
There was a problem hiding this comment.
| // We omit _data here because events only support bytes32 types. |
That's not true.
There was a problem hiding this comment.
This provide the option to bring your own token, or have one deployed for you.
There was a problem hiding this comment.
I think seeing Uniswap here is confusing. We might want to rename it and keep the impl, or even just capitulate and use an OZ impl (tho the one I added is ownable, so we do need a separate one).
There was a problem hiding this comment.
Since
- I removed the token from the gateway
- I didn't want to make this token ownable
I had to put the gateway into OVM_ETH.
There was a problem hiding this comment.
Shoot, this is mostly just the above file renamed... looks like I forgot to git mv it.
There was a problem hiding this comment.
Names of the OZ internal variables.
add changeset
eea2140 to
1e61f6a
Compare
1e61f6a to
2b89353
Compare
|
gonna break this up into small PRs, and build from master. |
chore: sync sc-feat/opcm2-add-cgt with develop
* fix(derive): Support modern action tests + holocene fixes * update commit
counterpartGateway()functions