Skip to content

feat[contracts]: ChugSplash action bundling logic#719

Merged
smartcontracts merged 5 commits intov0.4.0-rcfrom
feat/chugsplash-actions
May 4, 2021
Merged

feat[contracts]: ChugSplash action bundling logic#719
smartcontracts merged 5 commits intov0.4.0-rcfrom
feat/chugsplash-actions

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented May 1, 2021

Description
Includes logic for bundling actions of the form:

export interface SetCodeAction {
  target: string
  code: string
}

export interface SetStorageAction {
  target: string
  key: string
  value: string
}

export type ChugSplashAction = SetCodeAction | SetStorageAction

into a "bundle" object of the form:

export enum ChugSplashActionType {
  SET_CODE,
  SET_STORAGE,
}

export interface RawChugSplashAction {
  actionType: ChugSplashActionType
  target: string
  data: string
}

export interface ChugSplashActionBundle {
  root: string
  actions: Array<{
    action: RawChugSplashAction
    proof: {
      actionIndex: number
      siblings: string[]
    }
  }>
}

Where proof.actionIndex is the index of the action in the list of actions within the bundle and proof.siblings is the merkle proof for a given action.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: a773107

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smartcontracts smartcontracts changed the base branch from master to v0.4.0-rc May 3, 2021 18:16
@smartcontracts smartcontracts force-pushed the feat/chugsplash-actions branch from 153ce6a to cbcde41 Compare May 3, 2021 23:25
@smartcontracts smartcontracts marked this pull request as ready for review May 3, 2021 23:34
@smartcontracts smartcontracts added A-contracts C-feature Category: features labels May 3, 2021
maurelian
maurelian approved these changes May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smartcontracts smartcontracts merged commit 7330806 into v0.4.0-rc May 4, 2021
@smartcontracts smartcontracts deleted the feat/chugsplash-actions branch May 4, 2021 19:43
ben-chain pushed a commit to ben-chain/optimism that referenced this pull request May 6, 2021
@smartcontracts @ben-chain
feat[contracts]: ChugSplash action bundling logic (ethereum-optimism#719
bd7cf19 
)

* wip: adding chugsplash action bundling logic

* minor cleanup and comments

* lint: fix strange linting error

* test: Add mock contract for testing Merkle proofs
smartcontracts added a commit that referenced this pull request May 17, 2021
@smartcontracts
feat[contracts]: ChugSplash action bundling logic (#719)
865d05a 
* wip: adding chugsplash action bundling logic

* minor cleanup and comments

* lint: fix strange linting error

* test: Add mock contract for testing Merkle proofs
gakonst pushed a commit that referenced this pull request May 20, 2021
@smartcontracts @gakonst
feat[contracts]: ChugSplash action bundling logic (#719)
a481438 
* wip: adding chugsplash action bundling logic

* minor cleanup and comments

* lint: fix strange linting error

* test: Add mock contract for testing Merkle proofs
gakonst pushed a commit that referenced this pull request May 21, 2021
@smartcontracts @gakonst
feat[contracts]: ChugSplash action bundling logic (#719)
1e4b42e 
* wip: adding chugsplash action bundling logic

* minor cleanup and comments

* lint: fix strange linting error

* test: Add mock contract for testing Merkle proofs
smartcontracts added a commit that referenced this pull request May 30, 2021
@smartcontracts
feat[contracts]: ChugSplash action bundling logic (#719)
465323c 
* wip: adding chugsplash action bundling logic

* minor cleanup and comments

* lint: fix strange linting error

* test: Add mock contract for testing Merkle proofs
ben-chain pushed a commit to ben-chain/optimism that referenced this pull request Jun 23, 2021
@smartcontracts @ben-chain
feat[contracts]: ChugSplash action bundling logic (ethereum-optimism#719
cbe0288 
)

* wip: adding chugsplash action bundling logic

* minor cleanup and comments

* lint: fix strange linting error

* test: Add mock contract for testing Merkle proofs
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
feat(executor): Clean ups (#719)
f1f7868 
* feat(executor): Clean ups

* update

* doc test

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maurelian maurelian maurelian approved these changes

@ben-chain ben-chain Awaiting requested review from ben-chain ben-chain is a code owner

Assignees

No one assigned

Labels

C-feature Category: features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smartcontracts @maurelian