Skip to content

Generate test coverage reports for smart contracts in CI#714

Closed
maurelian wants to merge 1 commit intov0.3.0-rcfrom
chore/627/testCoverage
Closed

Generate test coverage reports for smart contracts in CI#714
maurelian wants to merge 1 commit intov0.3.0-rcfrom
chore/627/testCoverage

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Description:

This PR should run a new Test Coverage step in the Github Actions typescript / contracts workflow.

Worth noting:

  • Gas regression tests (ie. in files ending with .gas.spec.ts) were previously labelled with @skip-on-coverage. Those tests will not be run during test coverage (per .solcover.js).
  • Some 'behavioral' tests (ie. non-gas metering tests) are currently breaking during test coverage generation. This is not great, but I think it's OK to allow for now. The alternative is to skip those tests too, but that will reduce the accuracy of our coverage reports.

See other comments in my self-review.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 30, 2021

⚠️ No Changeset found

Latest commit: 2eae9c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chore[contracts]: git ignore coverage output
.gitignore Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output of test coverage is:

  1. A json file: packages/contracts/coverage.json
  2. A directory with other stuff packages/contracts/coverage/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solidity Coverage runs out of memory, at least on my machine, unless this NODE_OPTIONS prefix used.

@maurelian maurelian force-pushed the chore/627/testCoverage branch from ffdd4e0 to 2eae9c0 Compare April 30, 2021 20:41
@maurelian maurelian closed this Apr 30, 2021
OptimismBot pushed a commit that referenced this pull request Dec 1, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
* feat: add CGT system feature (#703)

* fix: sys feature CI (#706)

* fix: liquidity controller fuzz (#708)

* fix: setup CGT system feature in deploy script (#711)

* fix: unused import (#713)

* test: add CGT missing tests (#714)
OptimismBot pushed a commit that referenced this pull request Dec 8, 2025
* feat: add CGT system feature (#703)

* fix: sys feature CI (#706)

* fix: liquidity controller fuzz (#708)

* fix: setup CGT system feature in deploy script (#711)

* fix: unused import (#713)

* test: add CGT missing tests (#714)
OptimismBot pushed a commit that referenced this pull request Dec 9, 2025
* feat: add CGT system feature (#703)

* fix: sys feature CI (#706)

* fix: liquidity controller fuzz (#708)

* fix: setup CGT system feature in deploy script (#711)

* fix: unused import (#713)

* test: add CGT missing tests (#714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant