Skip to content

build: fix mismatched npm versions#704

Closed
snario wants to merge 1 commit intomasterfrom
liam/fix-mismatch-npm-versions
Closed

build: fix mismatched npm versions#704
snario wants to merge 1 commit intomasterfrom
liam/fix-mismatch-npm-versions

Conversation

@snario
Copy link
Copy Markdown
Contributor

@snario snario commented Apr 30, 2021

Fixes mismatched npm versions via syncpack

https://github.com/JamieMason/syncpack#fix-mismatches

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 30, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: e720502

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@snario snario marked this pull request as draft April 30, 2021 00:15
@gakonst
Copy link
Copy Markdown
Contributor

gakonst commented Apr 30, 2021

There seems to be a type incompatibility between sentry types and pino-sentry I believe.

@snario snario force-pushed the liam/fix-mismatch-npm-versions branch from 15b9723 to f5db233 Compare April 30, 2021 17:56
@snario snario requested review from gakonst and removed request for K-Ho, ben-chain, karlfloersch, maurelian, smartcontracts and tynes April 30, 2021 17:57
@snario snario force-pushed the liam/fix-mismatch-npm-versions branch from f5db233 to e720502 Compare April 30, 2021 17:58
@snario snario marked this pull request as ready for review April 30, 2021 17:59
annieke
annieke approved these changes Apr 30, 2021
View reviewed changes
packages/batch-submitter/src/exec/run-batch-submitter.ts
const l1Provider = new providers.JsonRpcProvider(requiredEnvVars.L1_NODE_WEB3_URL)
const l2Provider = injectL2Context(
new JsonRpcProvider(requiredEnvVars.L2_NODE_WEB3_URL)
new providers.JsonRpcProvider(requiredEnvVars.L2_NODE_WEB3_URL)
Copy link
Copy Markdown
Contributor

@annieke annieke Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need to be in this PR but seems like we may be able to deprecate usage of @ethersproject/providers across packages

@gakonst
Copy link
Copy Markdown
Contributor

gakonst commented Apr 30, 2021

@snario this PR may be worth doing incrementally, there's lots of dependency hell with incompatible versions here...

@snario
Copy link
Copy Markdown
Contributor Author

snario commented Apr 30, 2021

Yeah, let's do that.

@snario snario closed this Apr 30, 2021
@snario snario deleted the liam/fix-mismatch-npm-versions branch April 30, 2021 18:49
OptimismBot pushed a commit that referenced this pull request Dec 3, 2025
@0xDiscotech
fix: remove todo and update fees depositor address on mainnet (#704)
2640620
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2025
@0xDiscotech
chore: update fees depositor address and min withdrawal amount on gen…
c59e981 
…esis (#18490)

* fix: remove todo and update fees depositor address on mainnet (#704)

* chore: set genesis min withdrawal threshold from ten to two eth (#723)

* fix: remove unused errors (#726)
OptimismBot pushed a commit that referenced this pull request Jan 13, 2026
@0xDiscotech @0xOneTony
chore: update fees depositor address and min withdrawal amount on gen…
9943d8c 
…esis (#18490)

* fix: remove todo and update fees depositor address on mainnet (#704)

* chore: set genesis min withdrawal threshold from ten to two eth (#723)

* fix: remove unused errors (#726)
maurelian added a commit that referenced this pull request Jan 14, 2026
@0xOneTony @0xDiscotech @maurelian
chore: update fees depositor address and min withdrawal amounts (#18736)
018f5ae 
* chore: update fees depositor address and min withdrawal amount on genesis (#18490)

* fix: remove todo and update fees depositor address on mainnet (#704)

* chore: set genesis min withdrawal threshold from ten to two eth (#723)

* fix: remove unused errors (#726)

* fix: do not use fallback artifacts on PRs branches other than develop

---------

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gakonst gakonst Awaiting requested review from gakonst

1 more reviewer

@annieke annieke annieke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snario @gakonst @annieke