Skip to content

fix: ensure hardhat does not fail if no input sources provided#688

Merged
gakonst merged 3 commits intomasterfrom
liam/no-sources
May 2, 2021
Merged

fix: ensure hardhat does not fail if no input sources provided#688
gakonst merged 3 commits intomasterfrom
liam/no-sources

Conversation

@snario
Copy link
Copy Markdown
Contributor

@snario snario commented Apr 29, 2021

Implementing proposed fix from #674.

@snario snario requested a review from smartcontracts as a code owner April 29, 2021 18:47
@snario
Copy link
Copy Markdown
Contributor Author

snario commented Apr 29, 2021 •
edited
Loading

ERC20-Example failed unit tests.

  1) ERC20 smart contract
       when using a deployed contract instance
         "before all" hook for "should assigns initial balance":
     Error: missing response (requestBody="{\"method\":\"eth_accounts\",\"params\":[],\"id\":46,\"jsonrpc\":\"2.0\"}", requestMethod="POST", serverError={"errno":"ECONNREFUSED","code":"ECONNREFUSED","syscall":"connect","address":"127.0.0.1","port":9545}, url="http://127.0.0.1:9545", code=SERVER_ERROR, version=web/5.1.0)
      at Logger.makeError (/home/runner/work/optimism/optimism/node_modules/@ethersproject/logger/lib/index.js:180:21)
      at Logger.throwError (/home/runner/work/optimism/optimism/node_modules/@ethersproject/logger/lib/index.js:189:20)
      at /home/runner/work/optimism/optimism/node_modules/@ethersproject/web/lib/index.js:213:36
      at step (/home/runner/work/optimism/optimism/node_modules/@ethersproject/web/lib/index.js:33:23)
      at Object.throw (/home/runner/work/optimism/optimism/node_modules/@ethersproject/web/lib/index.js:14:53)
      at rejected (/home/runner/work/optimism/optimism/node_modules/@ethersproject/web/lib/index.js:6:65)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

@snario snario marked this pull request as draft April 29, 2021 19:05
@snario
Copy link
Copy Markdown
Contributor Author

snario commented Apr 29, 2021

Will need to revisit this later, unclear why the test above is failing.

@ethereum-optimism ethereum-optimism deleted a comment from changeset-bot bot Apr 29, 2021
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 1, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 972e978

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/hardhat-ovm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smartcontracts smartcontracts marked this pull request as ready for review May 1, 2021 00:48
smartcontracts
smartcontracts previously approved these changes May 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smartcontracts smartcontracts dismissed their stale review May 1, 2021 00:49

Needs changeset

@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented May 1, 2021

Dismissed my previous review - needs changeset so this can be propagated into an npm release.

smartcontracts
smartcontracts requested changes May 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes[et]

@gakonst gakonst merged commit cc4b096 into master May 2, 2021
@gakonst gakonst deleted the liam/no-sources branch May 2, 2021 10:26
@snario snario mentioned this pull request May 3, 2021
Closed
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@snario @smartcontracts @gakonst
fix: ensure hardhat does not fail if no input sources provided (ether…
b850004 
…eum-optimism#688)

* fix: ensure hardhat does not fail if no input sources provided

* lint: fix

* chore: add changeset

Co-authored-by: smartcontracts <kelvinfichter@gmail.com>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
OptimismBot pushed a commit that referenced this pull request Nov 14, 2025
@agusduha
Merge pull request #688 from defi-wonderland/fix/cgt-develop-sync-2
adbdcb0 
fix: sync develop
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
fix(derive): Holocene SpanBatch prefix checks (#688)
3e21875 
* fix(derive): Holocene `SpanBatch` prefix checks

* simplify

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts requested changes

+1 more reviewer

@gakonst gakonst gakonst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snario @smartcontracts @gakonst