refactor: move logger, metrics, base-service to common-ts#683
Merged
refactor: move logger, metrics, base-service to common-ts#683
Conversation
🦋 Changeset detectedLatest commit: 73c4fa6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
snario
reviewed
Apr 28, 2021
packages/common-ts/.prettierrc.json
Outdated
Comment on lines
+1
to
+8
| { | ||
| "$schema": "http://json.schemastore.org/prettierrc", | ||
| "trailingComma": "es5", | ||
| "tabWidth": 2, | ||
| "semi": false, | ||
| "singleQuote": true, | ||
| "arrowParens": "always" | ||
| } |
Contributor
There was a problem hiding this comment.
I think it can be a symlink.
snario
approved these changes
Apr 28, 2021
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
…ptimism#683) * WIP: common-ts * remove common-ts files from core-utils * fix imports in bs and dtl * update dockerfiles * cleanup common-ts * add changeset and message relayer dependency * add dtl common-ts dependency * make .prettier rc symlink Co-authored-by: Liam Horne <liam@lihorne.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
as of now, our contracts package is not browser compatible due to core-utils requiring prom-client as a dependency. this refactor moves our internal dependencies into a new
common-tspackage and should unblock browser use of our contracts.Additional context
all the dockerfiles are fixed as well, but would love extra 👀 to make sure
common-tspublishing works!