Run codechecks in CI for gas cost benchmarking#672
Merged
elenadimitrova merged 2 commits intomasterfrom May 5, 2021
Merged
Conversation
|
3282851 to
b8fe675
Compare
2142c7c to
5298228
Compare
5298228 to
aade66d
Compare
maurelian
approved these changes
May 5, 2021
| files: ./packages/contracts/coverage.json | ||
| fail_ci_if_error: false | ||
| verbose: true | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: I think empty lines between jobs is nice to give a sense of separation.
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
* Run codechecks in CI for gas cost benchmarking * Add CC_SECRET env var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables comparison reports on gas cost delta against base. Will plug in thresholds checking in near future once we get an idea of a good tolerance level for that.