Dockerize Integration Tests by gakonst · Pull Request #670 · ethereum-optimism/optimism

gakonst · 2021-04-28T12:51:11Z

Fixes #654. depends on #669

changeset-bot · 2021-04-28T12:51:13Z

⚠️ No Changeset found

Latest commit: 7f8cfae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.github/workflows/integration.yml

ops/scripts/integration-tests.sh

ops/docker-compose.yml

tynes · 2021-04-30T20:26:08Z

integration-tests/hardhat.config.ts

  solidity: '0.7.6',
  ovm: {
-    solcVersion: '0.7.6',
+    solcVersion: '0.7.6-allow_kall_2', // temporary until we fix the build for 0.7.6


Should this be an env var with this as the default value?

No this is not supposed to be configurable. Kall support is exposed by the compiler now so this change is no longer required.

tynes · 2021-04-30T20:31:14Z

ops/docker/Dockerfile.monorepo

 # copy over solc to save time building (35+ seconds vs not doing this step)
 COPY --from=downloader solc /root/.cache/hardhat-nodejs/compilers/linux-amd64/solc-linux-amd64-v0.7.6+commit.7338295f
-COPY --from=downloader ovm-solc /root/.cache/hardhat-nodejs/compilers/ovm/0.7.6.js
+COPY --from=downloader ovm-solc /root/.cache/hardhat-nodejs/compilers/ovm/0.7.6-allow_kall_2.js


Can we copy the compilers directory over so that we don't need to hard code versions here?

tynes · 2021-04-30T20:36:15Z

This will be nice because it will allow us to run the integration tests in kind.

This will also require parameterizing the network related information such that an arbitrary network and address manager can be provided.

Is this solved for or should we open another issue for this specifically? I'd like to be able to run the integration tests against a testnet deployment, so things like the timeout need to be very configurable.

.github/workflows/integration.yml

tynes · 2021-04-30T23:30:25Z

One additional thing is that if we want to be able to run the integration tests against something that is not a testnet, we will need a hardhat environment to act as L1. We do not publish the hardhat image from this repo, I have published a hardhat repo in the past at ethereumoptimism/hardhat

gakonst · 2021-05-01T09:32:35Z

@tynes the tests take env vars as parameters: #669

Publishing a hardhat image / improving the dockerfile format seems out of scope of this PR.

snario · 2021-05-03T00:23:03Z

ops/scripts/integration-tests.sh

+
+if [[ ! -z "$URL" ]]; then
+    # get the addrs from the URL provided
+    ADDRESSES=$(curl --silent --retry-connrefused --retry $RETRIES --retry-delay 5 $URL)


snario · 2021-05-03T00:23:12Z

ops/scripts/integration-tests.sh

+
+# wait for the sequencer to be up
+curl \
+    --silent \


--fail --show-error

* test: add docker image for integration tests * feat: add to docker-compose with scale 0 * ci: run and publish integration tests to dockerhub * test: add option to not bring network up for docker integration tests * chore: add --fail --show-error to curl

chore(cgt): sync 4

* chore(derive): test and clean batch types * chore(derive): test span batch transactions * chore(derive): test span batch utils

gakonst requested review from karlfloersch and tynes April 28, 2021 12:51

gakonst force-pushed the test/configurable-integration branch from 09ebcf1 to f228618 Compare April 28, 2021 12:53

gakonst requested review from ben-chain, maurelian and smartcontracts as code owners April 28, 2021 12:53

gakonst force-pushed the test/dockerize-integration branch from 8a31706 to 7fc5bea Compare April 28, 2021 12:54

Base automatically changed from test/configurable-integration to master April 28, 2021 13:08

gakonst force-pushed the test/dockerize-integration branch 2 times, most recently from 46918cd to a1521e4 Compare April 28, 2021 13:51

tynes reviewed Apr 28, 2021

View reviewed changes

.github/workflows/integration.yml Outdated Show resolved Hide resolved

gakonst force-pushed the test/dockerize-integration branch from 4cd623c to e3705b4 Compare April 28, 2021 16:32

gakonst marked this pull request as draft April 28, 2021 16:34

tynes reviewed Apr 28, 2021

View reviewed changes

ops/scripts/integration-tests.sh Show resolved Hide resolved

gakonst self-assigned this Apr 28, 2021

tynes reviewed Apr 29, 2021

View reviewed changes

ops/docker-compose.yml Outdated Show resolved Hide resolved

gakonst force-pushed the test/dockerize-integration branch 3 times, most recently from 4c50b40 to d56a290 Compare April 30, 2021 18:23

gakonst marked this pull request as ready for review April 30, 2021 18:25

gakonst force-pushed the test/dockerize-integration branch from e13ebc9 to 87350f4 Compare April 30, 2021 19:38

gakonst requested review from tynes and removed request for ben-chain, karlfloersch, maurelian and smartcontracts April 30, 2021 19:40

tynes reviewed Apr 30, 2021

View reviewed changes

snario reviewed Apr 30, 2021

View reviewed changes

.github/workflows/integration.yml Show resolved Hide resolved

gakonst added 3 commits May 1, 2021 20:26

test: add docker image for integration tests

f1cc34d

feat: add to docker-compose with scale 0

a3e3e13

ci: run and publish integration tests to dockerhub

416a67d

gakonst force-pushed the test/dockerize-integration branch from 87350f4 to 416a67d Compare May 1, 2021 17:27

test: add option to not bring network up for docker integration tests

d8fce12

gakonst requested review from snario and tynes May 2, 2021 09:58

snario reviewed May 3, 2021

View reviewed changes

ops/scripts/integration-tests.sh

# wait for the sequencer to be up

curl \

--silent \

Copy link
Copy Markdown

Contributor

snario May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--fail --show-error

tynes approved these changes May 3, 2021

View reviewed changes

chore: add --fail --show-error to curl

7f8cfae

gakonst merged commit 5622660 into master May 3, 2021

gakonst deleted the test/dockerize-integration branch May 3, 2021 12:30

gakonst mentioned this pull request May 3, 2021

ci: use correct service name when building integration tests #737

Merged

OptimismBot pushed a commit that referenced this pull request Nov 10, 2025

Merge pull request #670 from defi-wonderland/chore/cgt-sync-4

0446411

chore(cgt): sync 4

theochap pushed a commit that referenced this pull request Dec 10, 2025

chore(derive): Test and Clean Batch Types (#670)

c2eb864

* chore(derive): test and clean batch types * chore(derive): test span batch transactions * chore(derive): test span batch utils

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dockerize Integration Tests#670

Dockerize Integration Tests#670
gakonst merged 5 commits intomasterfrom
test/dockerize-integration

gakonst commented Apr 28, 2021 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 28, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tynes Apr 30, 2021

Uh oh!

gakonst May 1, 2021

Uh oh!

tynes Apr 30, 2021

Uh oh!

tynes commented Apr 30, 2021

Uh oh!

Uh oh!

tynes commented Apr 30, 2021

Uh oh!

gakonst commented May 1, 2021 •

edited

Loading

Uh oh!

snario May 3, 2021

Uh oh!

snario May 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gakonst commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tynes Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

gakonst May 1, 2021

Choose a reason for hiding this comment

Uh oh!

tynes Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

tynes commented Apr 30, 2021

Uh oh!

Uh oh!

tynes commented Apr 30, 2021

Uh oh!

gakonst commented May 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snario May 3, 2021

Choose a reason for hiding this comment

Uh oh!

snario May 3, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gakonst commented Apr 28, 2021 •

edited

Loading

changeset-bot bot commented Apr 28, 2021 •

edited

Loading

gakonst commented May 1, 2021 •

edited

Loading