Skip to content

refactor: rename deployments filenames to remove colons#662

Merged
snario merged 2 commits intomasterfrom
liam/no-colons
Apr 28, 2021
Merged

refactor: rename deployments filenames to remove colons#662
snario merged 2 commits intomasterfrom
liam/no-colons

Conversation

@snario
Copy link
Copy Markdown
Contributor

@snario snario commented Apr 27, 2021

Temporarily addresses #558 until we do another deployment.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 27, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: f6776a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@snario snario force-pushed the liam/no-colons branch 2 times, most recently from 37a838b to 32e7985 Compare April 27, 2021 23:12
@snario snario requested review from tynes and removed request for ben-chain and maurelian April 28, 2021 00:36
@tynes
Copy link
Copy Markdown
Contributor

tynes commented Apr 28, 2021

This is important for @smartcontracts to review as this touches code that he has written. Ideally the files that are generated no longer have colons in them. There is a mapping between the name of the contract and the name that goes in the AddressManager so for consistency we should rename the contracts in the address manager as well. That could be done in another PR but needs to happen before another deployment

smartcontracts
smartcontracts approved these changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it's fine to merge this as a temporary fix since we have that other issue written up.

@snario snario merged commit f1f5bf2 into master Apr 28, 2021
@snario snario deleted the liam/no-colons branch April 28, 2021 20:20
@snario snario mentioned this pull request Apr 28, 2021
Closed
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@snario
refactor: rename deployments filenames to remove colons (ethereum-opt…
b33370e 
…imism#662)

* refactor: rename deployments filenames to remove colons

* build: add changeset
OptimismBot pushed a commit that referenced this pull request Oct 30, 2025
@hexshire
Merge pull request #662 from defi-wonderland/chore/cgt-sync-3
1f888ed 
chore: cgt sync 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

@tynes tynes Awaiting requested review from tynes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snario @tynes @smartcontracts