feat: v0.3.0 release candidate by karlfloersch · Pull Request #603 · ethereum-optimism/optimism

karlfloersch · 2021-04-23T22:03:02Z

Description
PR tracking all changes which go into v0.3.0

Metadata

changeset-bot · 2021-04-23T22:03:05Z

🦋 Changeset detected

Latest commit: 293a386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@eth-optimism/data-transport-layer	Minor
@eth-optimism/l2geth	Minor
@eth-optimism/integration-tests	Patch
@eth-optimism/contracts	Minor
@eth-optimism/batch-submitter	Minor
@eth-optimism/hardhat-ovm	Minor
@eth-optimism/message-relayer	Minor
@eth-optimism/core-utils	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/data-transport-layer/src/services/l1-ingestion/handlers/sequencer-batch-appended.ts

tynes · 2021-04-26T20:25:24Z

The failing test is:

@eth-optimism/contracts:       1) should successfully execute an EIP155Transaction

Co-authored-by: smartcontracts <smartcontracts@doge.org>

* feat[contracts]: Use standard RLP transaction format * fix[l2geth]: Encode transaction as RLP * fix: Correct gas estimation in integration tests * fix: Correct gas estimation in integration tests * Update packages/contracts/contracts/optimistic-ethereum/OVM/predeploys/OVM_SequencerEntrypoint.sol Co-authored-by: ben-chain <ben@pseudonym.party> * fix[contracts]: Use isCreate instead of checking target address * fix[contracts]: Minor optimization in SequencerEntrypoint * fix[contracts]: Pass max gas to contract call in EOA contract Co-authored-by: ben-chain <ben@pseudonym.party>

* feat[contracts]: Make ProxyEOA compatible with eip1967 * fix[contracts]: Fix bug introduced by indirect constant * chore[contracts]: Add changeset * Update .changeset/old-cycles-invite.md Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

* l2geth: remove ovmsigner Also reduce the diff Co-authored-by: smartcontracts * l2geth: add changeset

* l2geth: set rlp encoded tx in txmeta in RPC layer * l2geth: remove extra setter of txmeta * chore: add changeset

* feat[contracts]: Make ExecutionManager return data * fix[l2geth]: fix linting error * fix[contracts]: Fix build error * fix[contracts]: fix failing unit tests * Add changeset Co-authored-by: Karl Floersch <karl@karlfloersch.com>

* l2geth: api checks for 0 value * chore: add changeset * l2geth: remove check for specific gasprice

…619) * feat[contracts]: Use standard RLP transaction format (#566) * feat[contracts]: Use standard RLP transaction format * fix[l2geth]: Encode transaction as RLP * fix: Correct gas estimation in integration tests * fix: Correct gas estimation in integration tests * Update packages/contracts/contracts/optimistic-ethereum/OVM/predeploys/OVM_SequencerEntrypoint.sol Co-authored-by: ben-chain <ben@pseudonym.party> * fix[contracts]: Use isCreate instead of checking target address * fix[contracts]: Minor optimization in SequencerEntrypoint * fix[contracts]: Pass max gas to contract call in EOA contract Co-authored-by: ben-chain <ben@pseudonym.party> * feat[contracts]: Add value transfer to contract account * fix[contracts]: Tweak transfer logic and add tests * fix[geth]: Remove logic that rejects value gt 0 txs * fix: nonce issue in rpc tests * fix: use correct wallet in rpc value tests * Update rpc.spec.ts * cleanup: remove double definition * chore: add changeset * chore: add changeset * tests: delete dead test * l2geth: log the tx value * l2geth: pass through zero value at top level * test: receipt passes * test: more specifically set balance Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

* dtl: remove legacy decoding * tests: remove dead test * chore: add changeset

tynes · 2021-04-27T06:23:38Z

Will be deploying this at https://goerli.optimism.io on Tuesday

gakonst · 2021-04-27T07:26:38Z

I think we want a l2geth minor version changeset, currently there's only patches in this branch.

* Add Goerli v3 deployment * Add Goerli v3 to README

* dtl: syncing off by one error * chore: add changeset

* chore: add changeset * chore: add changeset * dtl: pass through value field * core-utils: update and test toRpcString * lint: fix * l2geth: parse value fields * chore: add changeset

* l2geth: prevent fees lower than 21000 * l2geth: remove old check for too high tx gaslimit * tests: update to use new min gas estimated value * chore: add changeset * test: update expected values * test: remove dead test

…0.3.0-rc

tynes · 2021-05-03T01:20:22Z

@karlfloersch The merge e29730d caused the tests to break, before pushing a merge we should test locally. All of my PRs based on e29730d were breaking for unknown reasons until I discovered that a commit that was merged in was breaking things

The only merge conflict was in `ExecutionManager.run`. Upstream didn't have return values while the v0.3.0-rc branch did.

* l2geth: remove tx type check in client * chore: add changeset

* dtl: prevent reference of null value * chore: add changeset

tynes · 2021-05-05T17:46:06Z

Linting is currently failing, will be fixed with a merge of master

smartcontracts · 2021-05-05T22:57:45Z

Needs one more rebase in order to fix the codechecks CI error

) * wip: Starting work on geth revert reasons during estimate gas fix: error in comment fix: I got things backwards fix: Use UnpackValues instead of Unpack Update l2geth/accounts/abi/abi.go Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add integration test for reverts fix: build error * chore: Add changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

tynes · 2021-05-10T20:00:07Z

Getting a rather interesting failure from the tests - codechecks is failing for the following reason:

Executing 1 codechecks files
MaxBufferError: stdout maxBuffer exceeded

tynes · 2021-05-10T20:19:28Z

This being merged into master is blocked by:

Update: these are no longer blocking as they are merged

* add migrate ETH functionality * contracts: add eth gateway docstring (#832) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

tynes · 2021-05-10T21:27:34Z

Flaky integration tests for the withdrawals were observed. Still not sure what is causing that

* feat: Attempt to decode txs as RLP first (#563) Co-authored-by: smartcontracts <smartcontracts@doge.org> * l2geth: remove eth_sendRawEthSignTransaction endpoint (#589) * feat[contracts]: Use standard RLP transaction format (#566) * feat[contracts]: Use standard RLP transaction format * fix[l2geth]: Encode transaction as RLP * fix: Correct gas estimation in integration tests * fix: Correct gas estimation in integration tests * Update packages/contracts/contracts/optimistic-ethereum/OVM/predeploys/OVM_SequencerEntrypoint.sol Co-authored-by: ben-chain <ben@pseudonym.party> * fix[contracts]: Use isCreate instead of checking target address * fix[contracts]: Minor optimization in SequencerEntrypoint * fix[contracts]: Pass max gas to contract call in EOA contract Co-authored-by: ben-chain <ben@pseudonym.party> * feat[contracts]: Make ProxyEOA compatible with eip1967 (#592) * feat[contracts]: Make ProxyEOA compatible with eip1967 * fix[contracts]: Fix bug introduced by indirect constant * chore[contracts]: Add changeset * Update .changeset/old-cycles-invite.md Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * l2geth: remove ovmsigner (#591) * l2geth: remove ovmsigner Also reduce the diff Co-authored-by: smartcontracts * l2geth: add changeset * l2geth: set rlp encoded tx in txmeta in RPC layer (ethereum-optimism#644) * l2geth: set rlp encoded tx in txmeta in RPC layer * l2geth: remove extra setter of txmeta * chore: add changeset * feat: Have ExecutionManager pass data upwards (ethereum-optimism#643) * feat[contracts]: Make ExecutionManager return data * fix[l2geth]: fix linting error * fix[contracts]: Fix build error * fix[contracts]: fix failing unit tests * Add changeset Co-authored-by: Karl Floersch <karl@karlfloersch.com> * rpc: only allow txs with no calldata when there is value (ethereum-optimism#645) * l2geth: api checks for 0 value * chore: add changeset * l2geth: remove check for specific gasprice * feat[contracts]: Add value transfer support to ECDSAContractAccount (ethereum-optimism#619) * feat[contracts]: Use standard RLP transaction format (#566) * feat[contracts]: Use standard RLP transaction format * fix[l2geth]: Encode transaction as RLP * fix: Correct gas estimation in integration tests * fix: Correct gas estimation in integration tests * Update packages/contracts/contracts/optimistic-ethereum/OVM/predeploys/OVM_SequencerEntrypoint.sol Co-authored-by: ben-chain <ben@pseudonym.party> * fix[contracts]: Use isCreate instead of checking target address * fix[contracts]: Minor optimization in SequencerEntrypoint * fix[contracts]: Pass max gas to contract call in EOA contract Co-authored-by: ben-chain <ben@pseudonym.party> * feat[contracts]: Add value transfer to contract account * fix[contracts]: Tweak transfer logic and add tests * fix[geth]: Remove logic that rejects value gt 0 txs * fix: nonce issue in rpc tests * fix: use correct wallet in rpc value tests * Update rpc.spec.ts * cleanup: remove double definition * chore: add changeset * chore: add changeset * tests: delete dead test * l2geth: log the tx value * l2geth: pass through zero value at top level * test: receipt passes * test: more specifically set balance Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * dtl: remove legacy encoding (ethereum-optimism#618) * dtl: remove legacy decoding * tests: remove dead test * chore: add changeset * Add Goerli v3 deployment (ethereum-optimism#651) * Add Goerli v3 deployment * Add Goerli v3 to README * dtlL fix syncing off by one (ethereum-optimism#687) * dtl: syncing off by one error * chore: add changeset * dtl: index the value field (ethereum-optimism#686) * chore: add changeset * chore: add changeset * dtl: pass through value field * core-utils: update and test toRpcString * lint: fix * l2geth: parse value fields * chore: add changeset * rpc: gas fixes (ethereum-optimism#695) * l2geth: prevent fees lower than 21000 * l2geth: remove old check for too high tx gaslimit * tests: update to use new min gas estimated value * chore: add changeset * test: update expected values * test: remove dead test * examples: fix waffle example + gas changes in tests (ethereum-optimism#724) * examples: fix waffle example * tests: update gas price in assertion * chore: add changeset * l2geth: estimate gas assertion in decimal * test: use configurable key * ops: delete extra whitespace (ethereum-optimism#731) * fix: prevent eth sendtransaction (ethereum-optimism#725) * api: prevent unsafe calls * api: fill in txmeta * chore: add changeset * chore: add changeset * l2geth + contracts: standard interface for systems contracts and userland contracts (ethereum-optimism#721) * l2geth: fix call returndata parsing * contracts: standardize simulateMessage and run to return bytes * chore: add changeset * chore: add changeset * l2geth: more simple decoding * contracts: remove named arguments * chore: fix linter errors * Add contract deployment to Kovan (ethereum-optimism#715) * fix: remove type check in rollup client (ethereum-optimism#750) * l2geth: remove tx type check in client * chore: add changeset * dtl: prevent null reference in L1 handler (ethereum-optimism#757) * dtl: prevent reference of null value * chore: add changeset * test: eth_call exceptions (ethereum-optimism#800) * feat[l2geth]: Pass up contract revert reasons during DoEstimateGas (ethereum-optimism#774) * wip: Starting work on geth revert reasons during estimate gas fix: error in comment fix: I got things backwards fix: Use UnpackValues instead of Unpack Update l2geth/accounts/abi/abi.go Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Add integration test for reverts fix: build error * chore: Add changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * chore: add changeset (ethereum-optimism#831) * Migrate ETH between gateways (ethereum-optimism#778) * add migrate ETH functionality * contracts: add eth gateway docstring (ethereum-optimism#832) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: smartcontracts <smartcontracts@doge.org> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com>

closes alloy-rs/op-alloy#601 these are all omitifempty in geth and we need to use serde default here https://github.com/ethereum-optimism/op-geth/blob/35cdfe9f1d250781d4184f3474ac37c2d489de2f/beacon/engine/types.go#L52-L62

karlfloersch mentioned this pull request Apr 23, 2021

feat: RLP transactions #567

Closed

karlfloersch commented Apr 23, 2021

View reviewed changes

packages/data-transport-layer/src/services/l1-ingestion/handlers/sequencer-batch-appended.ts Outdated Show resolved Hide resolved

karlfloersch force-pushed the v0.3.0-rc branch from 89213c1 to 24cd2e7 Compare April 24, 2021 01:33

karlfloersch and others added 5 commits April 26, 2021 13:44

feat: Attempt to decode txs as RLP first (#563)

303e338

Co-authored-by: smartcontracts <smartcontracts@doge.org>

l2geth: remove eth_sendRawEthSignTransaction endpoint (#589)

0629e79

l2geth: remove ovmsigner (#591)

39356ec

* l2geth: remove ovmsigner Also reduce the diff Co-authored-by: smartcontracts * l2geth: add changeset

tynes force-pushed the v0.3.0-rc branch from bbd9dd1 to 39356ec Compare April 26, 2021 20:45

tynes and others added 4 commits April 26, 2021 15:55

l2geth: set rlp encoded tx in txmeta in RPC layer (#644)

5c7ea55

* l2geth: set rlp encoded tx in txmeta in RPC layer * l2geth: remove extra setter of txmeta * chore: add changeset

feat: Have ExecutionManager pass data upwards (#643)

bda36a4

* feat[contracts]: Make ExecutionManager return data * fix[l2geth]: fix linting error * fix[contracts]: Fix build error * fix[contracts]: fix failing unit tests * Add changeset Co-authored-by: Karl Floersch <karl@karlfloersch.com>

rpc: only allow txs with no calldata when there is value (#645)

42a69b6

* l2geth: api checks for 0 value * chore: add changeset * l2geth: remove check for specific gasprice

tynes marked this pull request as ready for review April 27, 2021 00:05

tynes requested review from annieke, ben-chain, maurelian, smartcontracts and tynes as code owners April 27, 2021 00:05

dtl: remove legacy encoding (#618)

0ef8cec

* dtl: remove legacy decoding * tests: remove dead test * chore: add changeset

karlfloersch and others added 5 commits April 27, 2021 14:59

Add Goerli v3 deployment (#651)

3d3b298

* Add Goerli v3 deployment * Add Goerli v3 to README

dtlL fix syncing off by one (#687)

435cfd4

* dtl: syncing off by one error * chore: add changeset

dtl: index the value field (#686)

0f4a17e

* chore: add changeset * chore: add changeset * dtl: pass through value field * core-utils: update and test toRpcString * lint: fix * l2geth: parse value fields * chore: add changeset

rpc: gas fixes (#695)

4eff927

* l2geth: prevent fees lower than 21000 * l2geth: remove old check for too high tx gaslimit * tests: update to use new min gas estimated value * chore: add changeset * test: update expected values * test: remove dead test

Merge branch 'master' of github.com:ethereum-optimism/optimism into v…

e29730d

…0.3.0-rc

maurelian and others added 5 commits May 3, 2021 21:48

chore: fix linter errors

06c34c7

Add contract deployment to Kovan (#715)

2f14d68

Merge branch 'master' into v0.3.0-rc

9ea9923

The only merge conflict was in `ExecutionManager.run`. Upstream didn't have return values while the v0.3.0-rc branch did.

fix: remove type check in rollup client (#750)

3583727

* l2geth: remove tx type check in client * chore: add changeset

dtl: prevent null reference in L1 handler (#757)

e5ee50d

* dtl: prevent reference of null value * chore: add changeset

Merge branch 'master' into v0.3.0-rc

812b5ed

ben-chain and others added 4 commits May 8, 2021 00:16

test: eth_call exceptions (#800)

7a92d60

Merge branch 'master' into v0.3.0-rc

9525653

chore: add changeset (#831)

193216d

github-actions bot added A-contracts A-ops Area: ops labels May 10, 2021

Merge branch 'master' into v0.3.0-rc

3171478

smartcontracts mentioned this pull request May 10, 2021

tests fail ethereum-optimism/optimism-tutorial#28

Closed

Migrate ETH between gateways (#778)

293a386

* add migrate ETH functionality * contracts: add eth gateway docstring (#832) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

tynes merged commit b799caa into master May 10, 2021

maurelian mentioned this pull request Jun 28, 2021

fix(contracts): prevent L2->L1 calls to system contracts #1183

Merged

theochap pushed a commit that referenced this pull request Dec 10, 2025

chore(ci): Pin action tests monorepo rev (#603)

896339d

emhane pushed a commit that referenced this pull request Feb 4, 2026

fix: docs after upstream pull (#603)

7341ed1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: v0.3.0 release candidate#603

feat: v0.3.0 release candidate#603
tynes merged 31 commits intomasterfrom
v0.3.0-rc

karlfloersch commented Apr 23, 2021 •

edited by smartcontracts

Loading

Uh oh!

changeset-bot bot commented Apr 23, 2021 •

edited

Loading

Uh oh!

Uh oh!

tynes commented Apr 26, 2021

Uh oh!

tynes commented Apr 27, 2021

Uh oh!

gakonst commented Apr 27, 2021

Uh oh!

tynes commented May 3, 2021

Uh oh!

tynes commented May 5, 2021

Uh oh!

smartcontracts commented May 5, 2021

Uh oh!

tynes commented May 10, 2021

Uh oh!

tynes commented May 10, 2021 •

edited

Loading

Uh oh!

tynes commented May 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

karlfloersch commented Apr 23, 2021 • edited by smartcontracts Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

tynes commented Apr 26, 2021

Uh oh!

tynes commented Apr 27, 2021

Uh oh!

gakonst commented Apr 27, 2021

Uh oh!

tynes commented May 3, 2021

Uh oh!

tynes commented May 5, 2021

Uh oh!

smartcontracts commented May 5, 2021

Uh oh!

tynes commented May 10, 2021

Uh oh!

tynes commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tynes commented May 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

karlfloersch commented Apr 23, 2021 •

edited by smartcontracts

Loading

changeset-bot bot commented Apr 23, 2021 •

edited

Loading

tynes commented May 10, 2021 •

edited

Loading