feat[contracts]: Have Messenger contracts emit an event on failed relay#596
Merged
smartcontracts merged 2 commits intomasterfrom Apr 23, 2021
Merged
feat[contracts]: Have Messenger contracts emit an event on failed relay#596smartcontracts merged 2 commits intomasterfrom
smartcontracts merged 2 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: 5825cda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
karlfloersch
approved these changes
Apr 23, 2021
Contributor
karlfloersch
left a comment
There was a problem hiding this comment.
I'm not code owner so take with a lil salt but this change LGTM! It's a great point by t11s that we need an event which confirms the message was picked up but that it failed to execute.
Here's the relevant watcher code for whoever is interested -
tynes
approved these changes
Apr 23, 2021
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
…ay (#596) * feat[contracts]: Have messengers emit events on failed relay * chore[contracts]: Add changeset
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* feat: kona-providers * fix: remove to_l2_block_ref utility * fix: no_std * fix: nits
theochap
added a commit
that referenced
this pull request
Jan 15, 2026
## Motivation According to the holocene spec, the length of the extra data must be exactly 9 bytes. See: https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/holocene/exec-engine.md#eip-1559-parameters-in-block-header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new event
FailedRelayedMessagetoL1CrossDomainMessengerandL2CrossDomainMessenger, to be emitted in the case that a relay failed. Alternative described in #587 was simply to add asuccessboolean toRelayedMessage, but some of our services rely on the currentRelayedMessageevent and I didn't want to break anything. I think this is good enough.Metadata