Closed
Conversation
tynes
reviewed
Dec 11, 2020
| 'appendStateBatch', | ||
| [batch, startBlock] | ||
| ) | ||
| if (tx.length < this.minTxSize) { |
Contributor
There was a problem hiding this comment.
I think that multiplying when setting this.minTxSize is safer, in case the variable ends up getting used elsewhere in the codebase
Contributor
Author
There was a problem hiding this comment.
Ah I like that! I'll change it -- one moment
Contributor
|
Ideally this is fixed before mainnet |
Contributor
|
@karlfloersch Was this applied to the batch submitter in the other repo? |
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
…napshot solidity: fail if updated gas snapshot isn't included
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
This PR addresses several typographical errors across various files in the project. The changes improve readability and maintain the professional standard of the documentation and code comments. Hope it helps Best regards, Elias.
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Apr 12, 2025
* contracts: scripts for L2 token deployment/verification See celo-org/celo-blockchain-planning#982 * contracts: Automatically read decimals for L2 tokens
QuentinI
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
May 27, 2025
* contracts: scripts for L2 token deployment/verification See celo-org/celo-blockchain-planning#982 * contracts: Automatically read decimals for L2 tokens
dailinsubjam
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Oct 4, 2025
* contracts: scripts for L2 token deployment/verification See https://github.com/celo-org/celo-blockchain-planning/issues/982 * contracts: Automatically read decimals for L2 tokens contracts: Convert `gen_l2_token_cmds` to std sh (#392) Changed shebang from #!/usr/bin/env fish to #!/bin/sh Replaced $argv with "$@" for command line arguments Replaced [ -z "$argv" ] with [ -z "$1" ] to check for arguments Replaced status filename with basename "$0" to get script name Changed return to exit 1 for script termination Used standard variable assignment and export syntax Used "$@" in the for loop to properly handle arguments with spaces Used $(...) for command substitution (POSIX compliant)
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Feb 2, 2026
* contracts: scripts for L2 token deployment/verification See celo-org/celo-blockchain-planning#982 * contracts: Automatically read decimals for L2 tokens contracts: Convert `gen_l2_token_cmds` to std sh (#392) Changed shebang from #!/usr/bin/env fish to #!/bin/sh Replaced $argv with "$@" for command line arguments Replaced [ -z "$argv" ] with [ -z "$1" ] to check for arguments Replaced status filename with basename "$0" to get script name Changed return to exit 1 for script termination Used standard variable assignment and export syntax Used "$@" in the for loop to properly handle arguments with spaces Used $(...) for command substitution (POSIX compliant)
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Feb 10, 2026
* contracts: scripts for L2 token deployment/verification See celo-org/celo-blockchain-planning#982 * contracts: Automatically read decimals for L2 tokens contracts: Convert `gen_l2_token_cmds` to std sh (#392) Changed shebang from #!/usr/bin/env fish to #!/bin/sh Replaced $argv with "$@" for command line arguments Replaced [ -z "$argv" ] with [ -z "$1" ] to check for arguments Replaced status filename with basename "$0" to get script name Changed return to exit 1 for script termination Used standard variable assignment and export syntax Used "$@" in the for loop to properly handle arguments with spaces Used $(...) for command substitution (POSIX compliant)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick bug fix where the state batch submitter was not using bytes for the MIN_TX_SIZE .
Contributing Agreement