Bedrock: fix new batcher, use sync status api, start from safe head#2897
Bedrock: fix new batcher, use sync status api, start from safe head#2897
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
trianglesphere
left a comment
There was a problem hiding this comment.
these changes look fine. Nice work marking the restarts way more efficient
7e82232 to
1523b66
Compare
|
Rebased onto |
`check_ports_inner` binds both a UDP and TCP socket to the supplied IP & PORT. This is invalid for binding to the advertised IP because the advertised IP is usually an external IP (either or a load balancer or the user's router when behind NAT at home or the machine's IP when running in docker) rather than an IP that the kernel is able to bind to. If the IP is not the same as the local IP of the context in which kona-node is running, OS Error 99: Cannot assign requested address is returned. This fixes a regression introduced in #2805
Previously the batcher would continue batch submitting from the L2 head.
However, if the sequencer runs while the batch submitter is offline, the L2 chain continues, and the batch-submitter will be skipping a part. This causes a reorg, after which the batch submitter can't recover without restart (since it didn't detect reorgs).
This PR fixes the above, to make restarting of sequencer and batcher work without so much disruption of the L2 chain.