Merged
Conversation
karlfloersch
approved these changes
Sep 26, 2020
Contributor
karlfloersch
left a comment
There was a problem hiding this comment.
Awesome! LGTM!
I heard from @tynes that the issue was that we had a fixed sized field which was including whitespace & that was breaking hex decoding when we tried to submit it. My understanding of this solution is to simply: 1) use TEXT so it can be dynamic length, and 2) trim() off any remaining whitespace in the signature. This seems good to go!
| ? tx.gasLimit.toString('hex', 64) | ||
| : '00'.repeat(32) | ||
| let signature: string = remove0x(tx.signature) | ||
| let signature: string = remove0x(tx.signature).trim() |
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
…output-submission Output submission specs and implementation
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
* bump * wrap up eots manager * fix compile * fuzz tests * fix e2e * a bunch of things * minor * fix e2e * fix * bump babylon * chore: removed daemoncmd and flags from main package * chore: add option to export finality provider on creation, usefull for generating fpd info without running chain * pr comments * chore: moved to finality-provider-export.md * chore: refactor export finality provider with more detailed flags * chore: removed unecessary comment * pr comments * chore: add description to export-finality-provider * fix: lint add err check * feat: add signature to fp exported (ethereum-optimism#288) * feat: add signature from bbn fp key to exported structure, helpfull to make sure the exported values were not modified by anyone in between phase-1 ~ phase2 * chore: merge rafilx/fp-creation-cli * chore: update fp_sig_hex * fix: misspell on md * chore: add link instruction to install binaries * chore: update markdown structure to prerequisites * chore: address pr comments, move export-fpd to export, misspells and short name exfpd to exfp * fix: lint remove empty line * chore: add warning to store the mnemonic * chore: remove omit empty values * chore: addressed md sugestions * chore: update package structure to have only one file in main package on finality-provider/cmd/fpd * feat: add option to start fpd without bbn chain * chore: bump version of protoc-gen-go-grpc v1.3.0 * chore: bump version of protoc-gen-go-grpc v1.3.0 and add grpc SignMessageFromChainKey * feat: add app func to sign any raw msg * chore: add pop to finality provider info * chore: refactory export cli command to connect with fpd daemon to export finality provider * fix: lint * chore: update md to reflect new export fpd context * chore: captalize subtitle * chore: add details to change chain-id on config * chore: reduce duplicated code * chore: update database folders txt * chore: break line * chore: update comment on FinalityProviderSigned * fix: update descriptions on ExportFinalityProvider cli command * chore: update flag name from no-bbn to no-chain-backend * chore: modified to create app by passing the chain controller in the function as parameter, instead of having 2 functions to create * fix: misspell etos to eots * fix: wrap lines to 80 characters * fix: wrap lines to 80 characters * chore: add reason why no chain backend is needed * chore: update description to create fpd * chore: remove babylond tx btcstaking create-finality-provider mention * chore: remove mention of comission * chore: add section for security consideration * fix: add instruction to update eots db path * chore: removed option to start fpd without backend chain * chore: removed export specific doc page, bring export example to finality-provider.md * chore: add specificatation to fpd created in db * chore: address comments on PR, mostly descriptions on md and flag usage --------- Co-authored-by: Runchao Han <me@runchao.rocks>
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Cleans up hardforks further to split bytecode into a legible directory.
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
Closes #288 --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rollup tx batches had a space in the serialized tx format from a padded space in the signature. This PR fixes that.
Contributing Agreement