Skip to content

indexer: use op-bindings for address manager#2858

Merged
mergify[bot] merged 3 commits intodevelopfrom
fix/indexer-op-bindings
Jun 27, 2022
Merged

indexer: use op-bindings for address manager#2858
mergify[bot] merged 3 commits intodevelopfrom
fix/indexer-op-bindings

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Jun 27, 2022

Description

The Lib_AddressManager contract was pulled into
contracts-bedrock as a legacy contract and can be
imported into op-bindings and build the same way that
the other golang contract bindings are maintained.

This is a legacy contract and should NEVER have any changes to it.
It is ok if it is compiled with a different compiler version for
testing, it will never be deployed to a network to be used with an
Optimism system again. It is very important that the ABI never changes.

Any upgrades to the network that touch this contract first must go
through a hardhat or anvil forked network to ensure correctness
of the upgrade.

The `Lib_AddressManager` contract was pulled into
`contracts-bedrock` as a legacy contract and can be
imported into `op-bindings` and build the same way that
the other golang contract bindings are maintained.

This is a legacy contract and should NEVER have any changes to it.
It is ok if it is compiled with a different compiler version for
testing, it will never be deployed to a network to be used with an
Optimism system again. It is very important that the ABI never changes.

Any upgrades to the network that touch this contract first must go
through a `hardhat` or `anvil` forked network to ensure correctness
of the upgrade.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 27, 2022

🦋 Changeset detected

Latest commit: 39fece1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/indexer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tynes tynes force-pushed the fix/indexer-op-bindings branch from 840a7ef to 5d6c6bc Compare June 27, 2022 18:53
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 0b30ae0 into develop Jun 27, 2022
@mergify mergify bot deleted the fix/indexer-op-bindings branch June 27, 2022 20:36
@mergify mergify bot removed the on-merge-train label Jun 27, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
…o payload attributes and system config (#2858)

## Description

Progress towards Jovian. Update repo deps (op-alloy, op-alloy-evm,
alloy-hardforks, ...) and adds the necessary min-base-fee data
structures. Also adds a min-base-fee field to the system config and
parse the config events to update it when the min-base-fee update is
received.

Progress towards #2829

---------

Co-authored-by: sadiq1971 <sadiqurr8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants