Skip to content

ci: Use conditional builds#2853

Merged
mergify[bot] merged 1 commit intodevelopfrom
feat/circle-efficiency
Jun 28, 2022
Merged

ci: Use conditional builds#2853
mergify[bot] merged 1 commit intodevelopfrom
feat/circle-efficiency

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

@mslipper mslipper commented Jun 27, 2022

  • Updates CircleCI jobs to exit early if the git diff doesn't require them to run. This will dramatically reduce our CircleCI usage and speed up the pipeline for projects like Bedrock that don't touch legacy code. The entire pipeline will still run on develop and master. The conditional logic is aware of package dependencies, so changing an upstream package will correctly trigger a build on downstream dependencies.
  • Creates a new ci-builder image to replace js-builder and go-builder. The ci-builder image contains everything we need to run builds on CircleCI.
  • Fixes a bunch of misspellings that should have failed the linter, but didn't.

You can see the conditional builds in action on this PR. The JS tests in the monorepo exit early but the integration tests still run since bss-core and the batch submitter changed. Here's a screenshot:

Screen Shot 2022-06-26 at 7 03 13 PM

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 27, 2022

⚠️ No Changeset found

Latest commit: 2732808

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the feat/circle-efficiency branch 5 times, most recently from 646ec9f to 0617c87 Compare June 27, 2022 01:07
@tynes
Copy link
Copy Markdown
Contributor

tynes commented Jun 27, 2022

Perhaps we could also delete all references to go-builder and js-builder from the repo?

- Updates CircleCI jobs to exit early if the git diff doesn't require them to run. This will dramatically reduce our CircleCI usage and speed up the pipeline for projects like Bedrock that don't touch legacy code. The entire pipeline will still run on `develop` and `master`. The conditional logic is aware of package dependencies, so changing an upstream package will correctly trigger a build on downstream dependencies.
- Creates a new `ci-builder` image to replace `js-builder` and `go-builder`. The `ci-builder` image contains everything we need to run builds on CircleCI.
- Fixes a bunch of misspellings that should have failed the linter, but didn't.
@mslipper mslipper force-pushed the feat/circle-efficiency branch from b0e5cda to 2732808 Compare June 28, 2022 05:32
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 28, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 68fc3fe into develop Jun 28, 2022
@mergify mergify bot deleted the feat/circle-efficiency branch June 28, 2022 05:38
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 28, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 28, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

Try to fix codecov flags config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants