Skip to content

fix(op-e2e): less flakey TestL2OutputSubmitter#2837

Merged
mergify[bot] merged 2 commits intodevelopfrom
m/debug-flakey-test
Jun 22, 2022
Merged

fix(op-e2e): less flakey TestL2OutputSubmitter#2837
mergify[bot] merged 2 commits intodevelopfrom
m/debug-flakey-test

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

@maurelian maurelian commented Jun 22, 2022

Description
Increase SubmissionFrequency and L2BlockTime in system_test.go which appears to greatly reduce the failures in TestL2OutputSubmitter.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 22, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 547b610

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper
Copy link
Copy Markdown
Contributor

mslipper commented Jun 22, 2022 

Failed
=== RUN   TestWithdrawals
    system_test.go:796: 
        	Error Trace:	system_test.go:796
        	Error:      	Expected nil, but got: context.deadlineExceededError{}
        	Test:       	TestWithdrawals
--- FAIL: TestWithdrawals (28.04s)

Might need to bump the deadline in withdrawals?

@maurelian maurelian force-pushed the m/debug-flakey-test branch from 03c303f to 547b610 Compare June 22, 2022 15:37
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit a046109 into develop Jun 22, 2022
@mergify mergify bot deleted the m/debug-flakey-test branch June 22, 2022 15:50
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 22, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
feat(node/proof): publish proof artifacts (#2837)
89c83bc 
## Description

Tentatively fix
#17357 and #2832

TODO:
- [ ] figure out a key to google cloud platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

+1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maurelian @mslipper @tynes