Skip to content

fix (bedrock): deploy L2OO - fix args#2836

Merged
mergify[bot] merged 2 commits intodevelopfrom
tux/fix-L200-deploy
Jun 22, 2022
Merged

fix (bedrock): deploy L2OO - fix args#2836
mergify[bot] merged 2 commits intodevelopfrom
tux/fix-L200-deploy

Conversation

@tuxcanfly
Copy link
Copy Markdown
Contributor

@tuxcanfly tuxcanfly commented Jun 22, 2022

Description
Fixed the order of the args to L2OO deploy script recently updated in #2830 which was causing L1 deploy scripts to fail with:

2028 [48b901ec] Error: ERROR processing /hive/contracts/deploy/000-L2OutputOracle.deploy.ts:
2029 [48b901ec] Error: incorrect data length (argument="_genesisL2Output", value=2, code=INVALID_ARGUMENT, version=abi/5.6.4)
2030 [48b901ec]     at Logger.makeError (/hive/contracts/node_modules/@ethersproject/logger/src.ts/index.ts:261:28)
2031 [48b901ec]     at Logger.throwError (/hive/contracts/node_modules/@ethersproject/logger/src.ts/index.ts:273:20)
2032 [48b901ec]     at Logger.throwArgumentError (/hive/contracts/node_modules/@ethersproject/logger/src.ts/index.ts:277:21)
2033 [48b901ec]     at FixedBytesCoder.Coder._throwError (/hive/contracts/node_modules/@ethersproject/abi/src.ts/coders/abstract-coder.ts:68:16)
2034 [48b901ec]     at FixedBytesCoder.encode (/hive/contracts/node_modules/@ethersproject/abi/src.ts/coders/fixed-bytes.ts:23:47)
2035 [48b901ec]     at /hive/contracts/node_modules/@ethersproject/abi/src.ts/coders/array.ts:71:19
2036 [48b901ec]     at Array.forEach (<anonymous>)
2037 [48b901ec]     at pack (/hive/contracts/node_modules/@ethersproject/abi/src.ts/coders/array.ts:54:12)
2038 [48b901ec]     at TupleCoder.encode (/hive/contracts/node_modules/@ethersproject/abi/src.ts/coders/tuple.ts:54:20)
2039 [48b901ec]     at AbiCoder.encode (/hive/contracts/node_modules/@ethersproject/abi/src.ts/abi-coder.ts:111:15)
2040 [48b901ec]     at DeploymentsManager.executeDeployScripts (/hive/contracts/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1222:19)
2041 [48b901ec]     at processTicksAndRejections (node:internal/process/task_queues:96:5)
2042 [48b901ec]     at async DeploymentsManager.runDeploy (/hive/contracts/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1052:5)
2043 [48b901ec]     at async SimpleTaskDefinition.action (/hive/contracts/node_modules/hardhat-deploy/src/index.ts:438:5)
2044 [48b901ec]     at async Environment._runTaskDefinition (/hive/contracts/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
2045 [48b901ec]     at async Environment.run (/hive/contracts/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
2046 [48b901ec]     at async SimpleTaskDefinition.action (/hive/contracts/node_modules/hardhat-deploy/src/index.ts:584:32)
2047 [48b901ec]     at async Environment._runTaskDefinition (/hive/contracts/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
2048 [48b901ec]     at async Environment.run (/hive/contracts/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
2049 [48b901ec]     at async SimpleTaskDefinition.action (/hive/contracts/node_modules/hardhat-deploy/src/index.ts:669:5)
2050 [48b901ec] error Command failed with exit code 1.
2051 [48b901ec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2052 [48b901ec] Deployed L1 contracts

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 22, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 02962ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

maurelian
maurelian approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 931e517 into develop Jun 22, 2022
@mergify mergify bot deleted the tux/fix-L200-deploy branch June 22, 2022 14:09
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 22, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@dhyaniarun1993
chore(supervisor): add supervisor grafana dashboard to kurtosis (#2836)
0678626 
optimism-package grafana expects the dashboard json inside the
`dashboards` folder in the provided sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maurelian maurelian maurelian approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

+1 more reviewer

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tuxcanfly @protolambda @maurelian