feat(sdk): use L2 chain ID as source of truth#2799
Merged
mergify[bot] merged 3 commits intodevelopfrom Jun 21, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 28960c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e33379e to
45781a9
Compare
roninjin10
reviewed
Jun 16, 2022
Contributor
roninjin10
left a comment
There was a problem hiding this comment.
lgtm but I read the pr on a phone screen so will give it another look in 15 to 30 minutes
Updates the SDK to use the L2 chain ID, instead of the L1 chain ID, as the source of truth when loading chain-specific data. We're going to need this now that we're planning to have multiple L2s attached to the same L1 (goerli) during our Bedrock testing plan. Part of a series of PRs meant to simplify the SDK and prepare it for Bedrock.
45781a9 to
3e31ba5
Compare
roninjin10
approved these changes
Jun 16, 2022
tynes
reviewed
Jun 21, 2022
tynes
approved these changes
Jun 21, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
Merge failed. Please see automated check logs for more details. |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nitaliano
pushed a commit
that referenced
this pull request
May 20, 2024
Updates the SDK to use the L2 chain ID, instead of the L1 chain ID, as the source of truth when loading chain-specific data. We're going to need this now that we're planning to have multiple L2s attached to the same L1 (goerli) during our Bedrock testing plan. Part of a series of PRs meant to simplify the SDK and prepare it for Bedrock. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
This PR contributes to issue #1040 to increase test coverage of the `kona-proof-interop` crate. It adds unit tests for: - `pre_state.rs`, reaching 77/78 lines covered (98.7%) - `hint.rs`, reaching 46/46 lines covered (100%) --------- Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the SDK to use the L2 chain ID, instead of the L1 chain ID, as
the source of truth when loading chain-specific data. We're going to
need this now that we're planning to have multiple L2s attached to the
same L1 (goerli) during our Bedrock testing plan. Part of a series of
PRs meant to simplify the SDK and prepare it for Bedrock.