Merged
Conversation
|
This adds 2 new cheatcodes to the `vm` interface, a `expectCall` that asserts on the call with a `msg.value` set to a specific amount as well as a `mockCall` that can send a specific amount of value as part of the mocked call.
Contributor
|
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
mslipper
approved these changes
May 18, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the rest of the predeploys to the bedrock contracts package. The commits are split up to include each contract + their tests. There are no tests for weth9, the contract is a copy/paste from what is currently running in production with tons of value locked.
OVM_ETHwas extended torevertforburnandmintSequencerFeeVaultwas updated to call the newL2StandardBridge- this could be updated to use the periphery dripper contract in theory, not sure if we want to do that since what we have has been working fine.DeployerWhitelisthas theownerstorage slot set toaddress(0)which turns it off, leaving its bytecode in there for historical reasons, there is a mapping for addresses that were whitelisted before arbitrary contract deployment was turned onforge-stddependency was updated to the latest version which includes the abi for new cheatcodes, seeexpectCallcheatcode overloaded withmsg.valueassertion foundry-rs/foundry#1568 - be sure tofoundryupto run this locally!