Skip to content

cleanup: Replace getNetwork() calls with getChainId()#2537

Closed
lucadonnoh wants to merge 1 commit intoethereum-optimism:developfrom
lucadonnoh:develop
Closed

cleanup: Replace getNetwork() calls with getChainId()#2537
lucadonnoh wants to merge 1 commit intoethereum-optimism:developfrom
lucadonnoh:develop

Conversation

@lucadonnoh
Copy link
Copy Markdown
Contributor

@lucadonnoh lucadonnoh commented May 3, 2022

Description
Replace getNetwork() calls with getChainId()

Metadata

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 3, 2022

🦋 Changeset detected

Latest commit: c47a5ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@eth-optimism/integration-tests Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code A-integration Area: integration tests labels May 3, 2022
@mergify mergify bot requested review from Inphi, mslipper and tynes May 3, 2022 21:10
@lucadonnoh
Copy link
Copy Markdown
Contributor Author

lucadonnoh commented May 3, 2022

nvm didn't see #2535 , anyway changing deploy-utils.ts breaks the integration test for me for some reason

@lucadonnoh lucadonnoh closed this May 3, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@sadiq1971 @emhane
feat(supervisor/core): [Safety Checker] validate interop timestamps (#…
d6dd74f 
…2537)

Closes #2431 
Closes #2433

---------

Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inphi Inphi Awaiting requested review from Inphi

@mslipper mslipper Awaiting requested review from mslipper

@tynes tynes Awaiting requested review from tynes

Assignees

No one assigned

Labels

A-integration Area: integration tests C-protocol-critical Category: Modifies protocol-critical code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace getNetwork() calls with getChainId()

1 participant

@lucadonnoh