Replace getNetwork() calls with getChainId() utility#2535
Merged
mergify[bot] merged 3 commits intoethereum-optimism:developfrom May 4, 2022
FlattestWhite:refactor-to-use-get-chain-id
Merged
Replace getNetwork() calls with getChainId() utility#2535mergify[bot] merged 3 commits intoethereum-optimism:developfrom FlattestWhite:refactor-to-use-get-chain-id
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
FlattestWhite:refactor-to-use-get-chain-id
Conversation
🦋 Changeset detectedLatest commit: 76a1c27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
smartcontracts
requested changes
May 3, 2022
Contributor
smartcontracts
left a comment
There was a problem hiding this comment.
Just got one minor fix for ya, everything else LGTM!
Contributor
Author
|
thanks @smartcontracts made the changes |
tynes
approved these changes
May 4, 2022
Contributor
Author
Done 👍 might need your approval to merge |
smartcontracts
approved these changes
May 4, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
Nice work! Drop an ETH address and I'll send you a contributor NFT :-) |
This was referenced May 4, 2022
Contributor
Author
My ETH address is richardguan.eth [0xc8e7817C4AC86EF3aFC525F150091391205b727C] - cheers :) |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview This PR completely removes the deprecated `RuntimeActor` from the `kona-node` service, along with all related functionality and documentation as requested in the issue. ## Changes Made ### Removed Files - **`docs/docs/pages/node/design/runtime.mdx`** - Complete Runtime system documentation - **`crates/node/service/src/actors/runtime.rs`** - RuntimeActor implementation ### Modified Files - **`docs/sidebar.ts`** - Removed Runtime link from navigation menu - **`crates/node/service/src/actors/mod.rs`** - Removed runtime module and exports - **`crates/node/service/src/lib.rs`** - Removed RuntimeActor, RuntimeContext, RuntimeState exports - **`crates/node/service/src/service/core.rs`** - Removed RuntimeActor associated type and runtime_builder method from RollupNodeService trait - **`crates/node/service/src/service/standard/node.rs`** - Removed RuntimeActor type alias and runtime_builder implementation - **`crates/node/service/src/service/standard/builder.rs`** - Removed runtime_load_interval field and with_runtime_load_interval method - **`bin/node/src/commands/node.rs`** - Removed `--l1.runtime-config-reload-interval` CLI argument and related functionality ## What Was Removed The RuntimeActor system provided dynamic configuration management and protocol version signaling by: - Monitoring L1 contracts for runtime parameter changes - Fetching configuration from System Config and Protocol Versions contracts - Signaling protocol version updates to the execution engine via `engine_signalSuperchainV1` - Managing periodic configuration reload intervals ## Verification - ✅ `kona-node-service` package compiles successfully - ✅ `kona-node` binary compiles successfully - ✅ All existing unit tests pass (13/13 tests) - ✅ Node binary runs and shows version information correctly - ✅ No breaking changes to existing functionality The removal was surgical and precise, maintaining all existing functionality while cleanly removing the entire deprecated RuntimeActor system. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Removes the mention of the `RuntimeActor` from the docs. It was removed in #2535
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
## Overview Removes the mention of the `RuntimeActor` from the docs. It was removed in #2535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring calls to getNetwork() with getChainId() utility exposed through
@eth-optimism/core-utils.Additional context
Add any other context about the problem you're solving.
Metadata