Skip to content

ci: check for changeset integrity#2415

Merged
mergify[bot] merged 2 commits intodevelopfrom
feat/changeset-integrity
Apr 6, 2022
Merged

ci: check for changeset integrity#2415
mergify[bot] merged 2 commits intodevelopfrom
feat/changeset-integrity

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Apr 4, 2022

Description
A new github action that errors if the changeset state isn't correct

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: ab3ea73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and cfromknecht April 4, 2022 21:16
@tynes tynes force-pushed the feat/changeset-integrity branch from 8e75bc2 to 77d3309 Compare April 4, 2022 21:16
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Apr 4, 2022

Unclear if that actually ran in CI, will need to take a look at it

@mslipper
Copy link
Copy Markdown
Contributor

mslipper commented Apr 4, 2022

You can test on a fork - that's how I've tested actions in the past.

cfromknecht
cfromknecht approved these changes Apr 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 6, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 6, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 98f8228 into develop Apr 6, 2022
@mergify mergify bot deleted the feat/changeset-integrity branch April 6, 2022 15:27
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
@tynes @mergify @nebojsa94
ci: check for changeset integrity (ethereum-optimism#2415)
a1ecd31 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
feat(node/service): Reset engine prior to block building (#2415)
be26db0 
## Overview

Sends an initial engine reset request and waits for it to conclude at
the startup of the `SequencerActor`. This initializes the `EngineState`,
and gives the sequencer a chain to begin building blocks on top of.

closes #2413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inphi Inphi Awaiting requested review from Inphi

2 more reviewers

@mslipper mslipper mslipper approved these changes

@cfromknecht cfromknecht cfromknecht approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @mslipper @cfromknecht