fixing issue where we can silently fail and stall block processing#237
Merged
willmeister merged 1 commit intomasterfrom Aug 28, 2020
Merged
Conversation
905610c to
d09d1f5
Compare
Inphi
pushed a commit
that referenced
this pull request
Aug 16, 2024
A lot of instructions in the MIPS spec require that certain fields be set to zero. Most of the time this isn't actually a problem but this can cause side-effects in a few cases. A buggy compiler could create an issue if it ever spit out non-compliant instructions. This PR implements those zero value enforcement checks for all instructions that we implement.
Inphi
pushed a commit
that referenced
this pull request
Aug 16, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Aug 20, 2024
A lot of instructions in the MIPS spec require that certain fields be set to zero. Most of the time this isn't actually a problem but this can cause side-effects in a few cases. A buggy compiler could create an issue if it ever spit out non-compliant instructions. This PR implements those zero value enforcement checks for all instructions that we implement.
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Aug 20, 2024
…imism#237)" (ethereum-optimism#281) This reverts commit 59e02fb3ece7fc249223054944a0b1ff437aa64f.
xibao-nr
pushed a commit
to node-real/combo-optimism
that referenced
this pull request
Feb 19, 2025
Prepare for v0.5.0 release
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
move to consensus, make them reusable
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
Fixes #237 Adds more concrete error variants for `OpProofsStorageError` Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where we don't re-throw when block subscription errors are caught, causing us to move on with block syncing and not re-fetch.
Metadata
Contributing Agreement