Skip to content

fix(rhc): typo in healthcheck docker-compose#2360

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/fix-typo-rhc-docker
Mar 24, 2022
Merged

fix(rhc): typo in healthcheck docker-compose#2360
smartcontracts merged 1 commit intodevelopfrom
sc/fix-typo-rhc-docker

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Fixes a typo in the primary docker-compose file. replica-healthcheck
should be replica_healthcheck to conform with the style used everywhere
else.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2022

⚠️ No Changeset found

Latest commit: 3b09fe9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work A-ops Area: ops labels Mar 24, 2022
Copy link
Copy Markdown
Contributor

@optimisticben optimisticben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes a typo in the primary docker-compose file. replica-healthcheck
should be replica_healthcheck to conform with the style used everywhere
else.
@smartcontracts smartcontracts force-pushed the sc/fix-typo-rhc-docker branch from 8f11224 to 3b09fe9 Compare March 24, 2022 19:28
@smartcontracts smartcontracts merged commit 3e995d8 into develop Mar 24, 2022
@smartcontracts smartcontracts deleted the sc/fix-typo-rhc-docker branch March 24, 2022 23:16
theochap added a commit that referenced this pull request Dec 10, 2025
…o engine actor. (#2360)

## Description

Small PR to move the node mode parameter from the `RollupNodeService`
trait to the `EngineActor`. This also improves the safety of the engine
select statement branch for incoming block building requests by being
able to catch communication drops from the sequencer engine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants