gas-oracle: allow configurable base fee poll interval#2358
Merged
Conversation
This commit adds a new config option that can be configured via argv with `--l1-base-fee-epoch-length-seconds` or an env var `GAS_PRICE_ORACLE_L1_BASE_FEE_EPOCH_LENGTH_SECONDS`. It defaults to 15 seconds. Ideally the implementation uses a duration flag instead of a uint64 flag, but that would be a breaking change for the config and this service will be deprecated in the future with the release of bedrock. By setting this value to a larger number, we are able to update the L1 base fee that is held in the L2 state less often. This will save the sequencer money, because it needs to front the costs of submitting these transactions.
🦋 Changeset detectedLatest commit: c535b3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Inphi
approved these changes
Mar 23, 2022
| Usage: "length of epochs in seconds", | ||
| EnvVar: "GAS_PRICE_ORACLE_EPOCH_LENGTH_SECONDS", | ||
| } | ||
| L1BaseFeeEpochLengthSecondsFlag = cli.Uint64Flag{ |
Contributor
There was a problem hiding this comment.
But what do you mean it'll be a breaking change to make this a duration? It's a new env flag so there shouldn't be any users to break.
Contributor
Author
There was a problem hiding this comment.
Ah sorry to clarify the flag directly above it is not a duration flag so i didn't make this one a duration flag, since they are similar config options
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
`op-node` spec is being updated and we need to stick to the versioned release to make sure to avoid compatibility issues in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a new config option that can be
configured via argv with
--l1-base-fee-epoch-length-secondsor an env var
GAS_PRICE_ORACLE_L1_BASE_FEE_EPOCH_LENGTH_SECONDS.It defaults to 15 seconds. Ideally the implementation uses a
duration flag instead of a uint64 flag, but that would be a
breaking change for the config and this service will be
deprecated in the future with the release of bedrock.
By setting this value to a larger number, we are able to update
the L1 base fee that is held in the L2 state less often.
This will save the sequencer money, because it needs to
front the costs of submitting these transactions.