feat: bss plaintext tx size enforcement#2332
Merged
mslipper merged 5 commits intoethereum-optimism:developfrom Mar 18, 2022
Merged
feat: bss plaintext tx size enforcement#2332mslipper merged 5 commits intoethereum-optimism:developfrom
mslipper merged 5 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 727b058 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
approved these changes
Mar 16, 2022
b34944b to
95367f2
Compare
This commit adds helper methods to extract some of the serialization logic into testable functions, and also add hooks to easily extend for future formats.
95367f2 to
727b058
Compare
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This PR refactors the node's reset handling module. This is required for handling reset due to failure while processing derivation update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the BSS to enforce the configured
MinTxSizeandMaxTxSizeon the plaintext encoding of calldata, regardless of which encoding scheme is used. Previously the only initial, conservative pass was performed against the plaintext size, after which (when using zlib) the min and max would be applied to the compressed calldata size. To ensure these are applied consistently, we now abort/prune based on the plaintext size before performing the final encoding. This protects against the edge case where the initial pass includes a maximum plaintext-sized batch, but the compressed size ends up being under the minimum.Metadata