various small BaseServiceV2 improvements#2315
Merged
smartcontracts merged 2 commits intodevelopfrom Mar 11, 2022
Merged
Conversation
Fixes the snake case function for metric names to properly account for strings which include "L1" or "L2". Normally these would be split into "L_1" and "L_2" respectively, but we want to join these since they're quite common and "L_1" looks silly.
Improves the log lines within BaseServiceV2 when the service is being shut down. Follows the pattern already laid out in the main() function which will log when key events happen.
🦋 Changeset detectedLatest commit: f776105 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2315 +/- ##
========================================
Coverage 80.08% 80.08%
========================================
Files 77 77
Lines 2460 2460
Branches 450 450
========================================
Hits 1970 1970
Misses 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tynes
approved these changes
Mar 11, 2022
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…ce (#2315) ## Description This PR inverts the way actors build their channels. Instead of emitting a list of `OutboundData` (channels to send data to) and using `InboundData` (channels to receive data from) as `Context`, it rather emits `InboundData` and uses `OutboundData` as context. This allows to define data flows where several actors send to the same receiver (using `mpsc` channels for instance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description