Skip to content

chore: change service generated env variables#2304

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
tonykogias:fix-base-service-v2-generated-env-variables
Mar 10, 2022
Merged

chore: change service generated env variables#2304
mslipper merged 1 commit intoethereum-optimism:developfrom
tonykogias:fix-base-service-v2-generated-env-variables

Conversation

@tonykogias
Copy link
Copy Markdown
Contributor

@tonykogias tonykogias commented Mar 10, 2022

Fixes the names of the service's generated env variables

Metadata

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 10, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 5cd1e99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@eth-optimism/common-ts Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #2304 (5cd1e99) into develop (3525635) will increase coverage by 16.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2304       +/-   ##
============================================
+ Coverage    80.08%   96.15%   +16.07%     
============================================
  Files           77       51       -26     
  Lines         2460     1508      -952     
  Branches       450      229      -221     
============================================
- Hits          1970     1450      -520     
+ Misses         490       58      -432
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer ?
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/data-transport-layer/src/utils/contracts.ts
packages/sdk/src/adapters/eth-bridge.ts
packages/sdk/src/adapters/dai-bridge.ts
packages/sdk/src/utils/misc-utils.ts
...kages/data-transport-layer/src/utils/validation.ts
packages/sdk/src/utils/contracts.ts
packages/sdk/src/index.ts
.../src/services/l2-ingestion/handlers/transaction.ts
...layer/src/services/l1-ingestion/handlers/errors.ts
packages/sdk/src/adapters/index.ts
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3525635...5cd1e99. Read the comment docs.

@tonykogias tonykogias requested a review from mslipper as a code owner March 10, 2022 02:02
smartcontracts
smartcontracts reviewed Mar 10, 2022
View reviewed changes
@tonykogias tonykogias marked this pull request as draft March 10, 2022 02:47
@tonykogias tonykogias marked this pull request as ready for review March 10, 2022 14:27
smartcontracts
smartcontracts previously approved these changes Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work (as usual!)

@smartcontracts smartcontracts dismissed their stale review March 10, 2022 16:46

Actually wait, needs a changeset

smartcontracts
smartcontracts reviewed Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we just need to add a changeset for the following packages:

  • message-relayer
  • replica-healthcheck
  • common-ts

smartcontracts
smartcontracts approved these changes Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@mslipper mslipper merged commit f50d1c4 into ethereum-optimism:develop Mar 10, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell
feat(book): Node Documentation (#2304)
22b1dd5 
### Description

Introduces a new section of the kona book that details the inner
workings of the `kona-node`.

Progress on #1135
Progress on #1134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

@optimisticben optimisticben Awaiting requested review from optimisticben

@tynes tynes Awaiting requested review from tynes

@mslipper mslipper Awaiting requested review from mslipper

Assignees

No one assigned

Labels

A-ops Area: ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Have BaseServiceV2 add spaces to environment variable names

4 participants

@tonykogias @codecov-commenter @smartcontracts @mslipper