Skip to content

linting: speed up with new config#2275

Merged
tynes merged 1 commit intodevelopfrom
lint-optimize
Mar 7, 2022
Merged

linting: speed up with new config#2275
tynes merged 1 commit intodevelopfrom
lint-optimize

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Mar 7, 2022

Description

typescript-eslint/typescript-eslint#3528

Cuts the run of linting from 68s to 44s on my local machine
with yarn lint at the root of the repo

Attempting to debug #2249, will rebase on top
of this commit to see if it fixes the oom error in that PR.

@tynes
linting: speed up with new config
127ea3c 
typescript-eslint/typescript-eslint#3528

Cuts the run of linting from 68s to 44s on my local machine
with `yarn lint` at the root of the repo
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 7, 2022

⚠️ No Changeset found

Latest commit: 127ea3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2022 •
edited
Loading

Codecov Report

Merging #2275 (127ea3c) into develop (51a527b) will increase coverage by 16.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2275       +/-   ##
============================================
+ Coverage    80.08%   96.15%   +16.07%     
============================================
  Files           77       51       -26     
  Lines         2460     1508      -952     
  Branches       450      229      -221     
============================================
- Hits          1970     1450      -520     
+ Misses         490       58      -432
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer ?
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/services/l2-ingestion/handlers/transaction.ts
packages/sdk/src/cross-chain-messenger.ts
.../l1-ingestion/handlers/sequencer-batch-appended.ts
packages/data-transport-layer/src/utils/index.ts
packages/sdk/src/utils/contracts.ts
packages/sdk/src/adapters/dai-bridge.ts
packages/sdk/src/adapters/index.ts
packages/sdk/src/utils/chain-constants.ts
packages/sdk/src/interfaces/types.ts
...ices/l1-ingestion/handlers/state-batch-appended.ts
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a527b...127ea3c. Read the comment docs.

@tynes tynes merged commit 11a633e into develop Mar 7, 2022
@tynes tynes deleted the lint-optimize branch March 7, 2022 20:14
theochap pushed a commit that referenced this pull request Dec 10, 2025
@itschaindev
test (supervisor/rpc): e2e test for allSafeDerivedAt and `crossDeri…
8e309de 
…vedToSource` (#2350)

Closes #2275
theochap pushed a commit that referenced this pull request Jan 14, 2026
@itschaindev
test (supervisor/rpc): e2e test for allSafeDerivedAt and `crossDeri…
6e02f17 
…vedToSource` (op-rs/kona#2350)

Closes #2275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @codecov-commenter @smartcontracts