maintance: replaced l2Provider with env.l2Provider#2162
maintance: replaced l2Provider with env.l2Provider#2162tynes merged 1 commit intoethereum-optimism:developfrom tonykogias:remove-variable-in-whitelist.spec.ts
Conversation
🦋 Changeset detectedLatest commit: 45642dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2162 +/- ##
========================================
Coverage 73.35% 73.35%
========================================
Files 84 84
Lines 2766 2766
Branches 472 472
========================================
Hits 2029 2029
Misses 737 737
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| envConfig, | ||
| DEFAULT_TEST_GAS_L1, | ||
| } from './shared/utils' | ||
| import { l1Provider, envConfig, DEFAULT_TEST_GAS_L1 } from './shared/utils' |
There was a problem hiding this comment.
Might as well also do this with l1Provider since we're at it!
| describe('OVM Context: Layer 2 EVM Context', () => { | ||
| const L2Provider = injectL2Context(l2Provider) | ||
| let env: OptimismEnv | ||
| let L2Provider: providers.JsonRpcProvider |
There was a problem hiding this comment.
Is this global L2Provider used? Can we use the env.l2Provider?
integration-tests/test/rpc.spec.ts
Outdated
| let wallet: Wallet | ||
|
|
||
| const provider = injectL2Context(l2Provider) | ||
| let provider: providers.JsonRpcProvider |
There was a problem hiding this comment.
This provider could probably be replaced with env.l2Provider
|
@tynes @smartcontracts I think that all those variables are the same, should I just replace them with |
|
Yeah I think it would be best to replace every usage of the global l1Provider and l2Provider variables with |
|
@smartcontracts I made a new commit let me know if that works. |
|
Do you mind adding a changeset for the integration tests, fixing the merge conflict and then squashing into a single commit? |
Done! Let me know if it needs anything else. |
smartcontracts
left a comment
There was a problem hiding this comment.
Great work as usual!
### Description Creates an rpc server for the `kona-node` that will service the supervisor. Progress on #2108
Description
Replaced l2Provider with env.l2Provider in whitelist.spec.ts, rpc.spec.ts & ovmcontext.spec.ts
Metadata