Skip to content

Fix Typo In Comment#2121

Merged
smartcontracts merged 1 commit intoethereum-optimism:developfrom
bbayazit16:develop
Feb 3, 2022
Merged

Fix Typo In Comment#2121
smartcontracts merged 1 commit intoethereum-optimism:developfrom
bbayazit16:develop

Conversation

@bbayazit16
Copy link
Copy Markdown
Contributor

@bbayazit16 bbayazit16 commented Feb 2, 2022

Change "crtiical" to "critical" in line 23.

@bbayazit16
Fix Typo In Comment - Line 23
0f3f046 
crtiical -> critical
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 2, 2022

⚠️ No Changeset found

Latest commit: 0f3f046

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bbayazit16 bbayazit16 changed the title Fix Typo In Comment - Line 23 Fix Typo In Comment Feb 2, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #2121 (0f3f046) into develop (f3989c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2121   +/-   ##
========================================
  Coverage    72.63%   72.63%           
========================================
  Files           85       85           
  Lines         2872     2872           
  Branches       469      469           
========================================
  Hits          2086     2086           
  Misses         786      786
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 37.74% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 68.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3989c0...0f3f046. Read the comment docs.

@smartcontracts smartcontracts merged commit fc0b313 into ethereum-optimism:develop Feb 3, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
fix(node/p2p): fix opp2p_peers rpc handler. Only return total peer sc…
b86adba 
…ore (#2121)

## Description

This PR amends some of the changes from #2118 to only serve the total
peer score inside `opp2p_peers`, as this is the only field supported by
`rust_libp2p` as of now.

See libp2p/rust-libp2p#6058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bbayazit16 @codecov-commenter @tynes @smartcontracts