Skip to content

test: improve test coverage for aliasing#2100

Merged
smartcontracts merged 1 commit intoethereum-optimism:developfrom
RasenGUY:develop
Jan 30, 2022
Merged

test: improve test coverage for aliasing#2100
smartcontracts merged 1 commit intoethereum-optimism:developfrom
RasenGUY:develop

Conversation

@RasenGUY
Copy link
Copy Markdown
Contributor

@RasenGUY RasenGUY commented Jan 29, 2022 •
edited
Loading

Description
This commit improves the test coverage for address aliasing to 100% in packages/core-utils/alias.spec.ts

Additional context

  • added two additional error messages to check against

Metadata

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 29, 2022

⚠️ No Changeset found

Latest commit: 0884013

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-pkg-core-utils Area: packages/core-utils label Jan 29, 2022
@RasenGUY
Copy link
Copy Markdown
Contributor Author

RasenGUY commented Jan 29, 2022 •
edited
Loading

@smartcontracts I closed the other pr and opened this new one, as I had to figure out how to properly keep up to date with the develop branch on my local machine. I updated the commit message as requested, and rebased against develop. hopefully this works. Mind My noobishness, this is my first time contributing.

@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented Jan 29, 2022

No problem @RasenGUY! Thank you :-) running the integration tests now

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 29, 2022 •
edited
Loading

Codecov Report

Merging #2100 (0884013) into develop (dfd22e6) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2100      +/-   ##
===========================================
+ Coverage    75.30%   75.37%   +0.07%     
===========================================
  Files           81       81              
  Lines         2705     2705              
  Branches       436      436              
===========================================
+ Hits          2037     2039       +2     
+ Misses         668      666       -2
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (+0.55%) ⬆️
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 86.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-utils/src/alias.ts 100.00% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd22e6...0884013. Read the comment docs.

@RasenGUY
Copy link
Copy Markdown
Contributor Author

RasenGUY commented Jan 29, 2022

No problem @RasenGUY! Thank you :-) running the integration tests now

I'l take a stab at other similar issues, if that's ok with you guys ?

@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented Jan 30, 2022

No problem @RasenGUY! Thank you :-) running the integration tests now

I'l take a stab at other similar issues, if that's ok with you guys ?

Of course! You're welcome to tackle as many issues as you'd like :-) Let me know if you ever need any assistance

@smartcontracts smartcontracts merged commit 36151fe into ethereum-optimism:develop Jan 30, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
feat(node/test-devstack): update devstack configuration to large netw…
d2acbec 
…orks (#2144)

## Description

Adapt the devstack configuration files (called presets) to be compatible
with large network configuration files.

Progress towards #2100
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
test(node/e2e-devstack): deprecate p2p tests in devnet-sdk (#2159)
b752af8 
## Description

Deprecate p2p tests in `devnet-sdk` now we have full-feature equivalence
inside the `devstack`.

Adds a finalized sync test.

Close #2100
theochap added a commit that referenced this pull request Jan 14, 2026
@theochap
feat(node/test-devstack): update devstack configuration to large netw…
55a041e 
…orks (op-rs/kona#2144)

## Description

Adapt the devstack configuration files (called presets) to be compatible
with large network configuration files.

Progress towards #2100
theochap added a commit that referenced this pull request Jan 14, 2026
@theochap
test(node/e2e-devstack): deprecate p2p tests in devnet-sdk (op-rs/kon…
743b728 
…a#2159)

## Description

Deprecate p2p tests in `devnet-sdk` now we have full-feature equivalence
inside the `devstack`.

Adds a finalized sync test.

Close #2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve test coverage for address aliasing utils

3 participants

@RasenGUY @smartcontracts @codecov-commenter