Skip to content

feat(sdk): implement depositETH#2081

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-deposit-eth
Jan 26, 2022
Merged

feat(sdk): implement depositETH#2081
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-deposit-eth

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented Jan 26, 2022

Description
Implements the depositETH function for the SDK.

Metadata

  • Fixes ENG-1828

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 26, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: b822608

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #2081 (4ce9ff7) into develop (a7e8ba9) will decrease coverage by 7.72%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2081      +/-   ##
===========================================
- Coverage    74.79%   67.07%   -7.73%     
===========================================
  Files           81       81              
  Lines         2698     2700       +2     
  Branches       433      435       +2     
===========================================
- Hits          2018     1811     -207     
- Misses         680      889     +209
Flag Coverage Δ
batch-submitter 62.50% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 57.73% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 30.38% <57.14%> (-54.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/cross-chain-messenger.ts 25.42% <57.14%> (-27.21%) ⬇️
packages/sdk/src/cross-chain-provider.ts 5.21% <0.00%> (-82.47%) ⬇️
packages/sdk/src/utils/message-encoding.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/sdk/src/utils/coercion.ts 53.84% <0.00%> (-34.62%) ⬇️
packages/sdk/src/utils/contracts.ts 82.22% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e8ba9...4ce9ff7. Read the comment docs.

tynes
tynes reviewed Jan 26, 2022
View reviewed changes
@smartcontracts
feat(sdk): implement depositETH
b822608 
Implements the depositETH function for the upcoming Optimism JS SDK.
Very basic functionality, only allows users to deposit to their own
accounts. We can consider adding the ability to deposit to other
accounts as part of a future PR.
@smartcontracts smartcontracts merged commit 97c2f80 into develop Jan 26, 2022
@smartcontracts smartcontracts deleted the sc/sdk-deposit-eth branch January 26, 2022 19:43
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell
feat(p2p): Peers Rpc Endpoint Progress (#2081)
4e2a464 
### Description

Makes progress on #1562.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes left review comments

+1 more reviewer

@SmitV SmitV SmitV approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smartcontracts @codecov-commenter @tynes @SmitV