go/batch-submitter: HTTP/2 fixes#2078
Conversation
The built-in geth client has a bugger implementation of HTTP/2: ethereum/go-ethereum#24292. Additionally, Go 1.17 has better HTTP/2 support than Go 1.15. This PR updates the BSS to use Go 1.17 in built binaries, and adds a flag to disable HTTP/2 support if necessary.
🦋 Changeset detectedLatest commit: f0c3f93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
left a comment
There was a problem hiding this comment.
Ideally we won't need to run with disabling http2 once the next version of geth is released with that bug fix. Perhaps scope creep, but i don't think its a bad idea to configure the http client with a user agent that includes the version, this could be done simply by changing disableHTTP2 into httpOpts and calling this: https://github.com/ethereum/go-ethereum/blob/015fde9a2c4b6e722a9de5bfea2a14226806a231/rpc/client.go#L267
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2078 +/- ##
=======================================
Coverage 75.3% 75.3%
=======================================
Files 81 81
Lines 2705 2705
Branches 436 436
=======================================
Hits 2039 2039
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Update to go-ethereum v1.10.16. Release notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.10.16 This notably fixes the http2 bug in the rpc client. #2078 will be able to be reverted after this is merged in
Update to go-ethereum v1.10.16. Release notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.10.16 This notably fixes the http2 bug in the rpc client. #2078 will be able to be reverted after this is merged in
Update to go-ethereum v1.10.16. Release notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.10.16 This notably fixes the http2 bug in the rpc client. ethereum-optimism#2078 will be able to be reverted after this is merged in
The built-in geth client has a bugger implementation of HTTP/2: ethereum/go-ethereum#24292. Additionally, Go 1.17 has better HTTP/2 support than Go 1.15. This PR updates the BSS to use Go 1.17 in built binaries, and adds a flag to disable HTTP/2 support if necessary.