Skip to content

fixed file extensions in integration tests#2018

Merged
smartcontracts merged 1 commit intoethereum-optimism:developfrom
lucadonnoh:develop
Jan 16, 2022
Merged

fixed file extensions in integration tests#2018
smartcontracts merged 1 commit intoethereum-optimism:developfrom
lucadonnoh:develop

Conversation

@lucadonnoh
Copy link
Copy Markdown
Contributor

@lucadonnoh lucadonnoh commented Jan 16, 2022 •
edited
Loading

Description
changed bridged.tokens.ts file in integration tests to bridged.tokens.spec.ts and setup-docker-compose-network.js to setup-docker-compose-network.ts

Metadata

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 16, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: acfc9d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-integration Area: integration tests label Jan 16, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 16, 2022 •
edited
Loading

Codecov Report

Merging #2018 (acfc9d5) into develop (e634bf2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2018   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files           79       79           
  Lines         2554     2554           
  Branches       401      401           
========================================
  Hits          1905     1905           
  Misses         649      649
Flag Coverage Δ
batch-submitter 62.50% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 88.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e634bf2...acfc9d5. Read the comment docs.

@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented Jan 16, 2022

Looks like this line within the .js file needs to be updated:

const { DockerComposeNetwork } = require('./shared/docker-compose')

Should be:

import { DockerComposeNetwork } from './shared/docker-compose'

@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented Jan 16, 2022

You may also be able to delete this file: https://github.com/ethereum-optimism/optimism/blob/b7ff3b6cb6d2ed138a79f26259d3aa37eee8b479/integration-tests/mocha.opts

smartcontracts
smartcontracts reviewed Jan 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @lucadonnoh. Please just rebase your commits into a single commit, and use a commit message in the format fix: <description>. I'll approve once that's done!

@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented Jan 16, 2022

Great work, thank you! Approved. Feel free to send an email to (kelvin AT optimism DOT io) if you'd like a contributor NFT hand drawn by me :-)

@smartcontracts smartcontracts merged commit 3174f03 into ethereum-optimism:develop Jan 16, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
feat(node/p2p): support user agent and protocol version in opp2p_peer…
19e3ab5 
…s rpc call (#2018)

## Description

Adds more fields to the `opp2p_peers` rpc call. In particular we now
also support `user-agent` and `protocol_version` fields

Progress towards #1562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

A-integration Area: integration tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix file extensions in integration tests

3 participants

@lucadonnoh @codecov-commenter @smartcontracts