Conversation
…ributesBuilder System config update errors in `prepare_payload_attributes` were propagated as critical pipeline errors, halting derivation. One or more receipts may contain malformed or invalid config update logs, which should not be fatal. Change the error handling to log a warning and continue derivation instead. Closes: AQ-10 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
487eb66 to
8637200
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19503 +/- ##
===========================================
+ Coverage 75.3% 75.8% +0.5%
===========================================
Files 194 477 +283
Lines 11285 60033 +48748
===========================================
+ Hits 8502 45553 +37051
- Misses 2639 14480 +11841
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sebastianst
approved these changes
Mar 13, 2026
Member
sebastianst
left a comment
There was a problem hiding this comment.
Fix LGTM.
It's odd that we don't maintain a single view of the SystemConfig across all stages. That the attributes builder refetches the SystemConfig again after the L1Traversal already maintains its own view is something we should fix... We will fix this when migrating to a non-IO derivation pipeline.
ClaytonNorthey92
pushed a commit
to hemilabs/optimism
that referenced
this pull request
Mar 19, 2026
…ributesBuilder (ethereum-optimism#19503) System config update errors in `prepare_payload_attributes` were propagated as critical pipeline errors, halting derivation. One or more receipts may contain malformed or invalid config update logs, which should not be fatal. Change the error handling to log a warning and continue derivation instead. Closes: AQ-10 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
ClaytonNorthey92
pushed a commit
to hemilabs/optimism
that referenced
this pull request
Mar 23, 2026
…ributesBuilder (ethereum-optimism#19503) System config update errors in `prepare_payload_attributes` were propagated as critical pipeline errors, halting derivation. One or more receipts may contain malformed or invalid config update logs, which should not be fatal. Change the error handling to log a warning and continue derivation instead. Closes: AQ-10 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatefulAttributesBuilder::prepare_payload_attributes, theupdate_with_receiptscall propagated system config update errors as.crit(), halting the derivation pipelineattributes.go:97-99intentionally ignores these errors (_ = UpdateSystemConfigWithL1Receipts(...))PollingTraversal/IndexedTraversalin fix(kona/derive): make syscfg update failure non-fatal in L1Traversal #19358Fixes AQ-10:
update_with_receiptserror handling mismatch between kona'sStatefulAttributesBuilderand op-node'sPreparePayloadAttributes.Prior art
This follows the exact same pattern established in #19358 (LT-03) for the L1 traversal stages.
Op-node reference
Test plan
test_syscfg_update_error_is_nonfatal— constructs a malformed system config receipt and verifiesprepare_payload_attributessucceeds instead of returning a critical errorcargo check -p kona-derivepassescargo test -p kona-derive -- test_syscfg_update_error_is_nonfatalpasses🤖 Generated with Claude Code
Closes #19512