fix: Include Migrator address in ReadImplementationAddresses script output#18971
Closed
0xiamflux wants to merge 4 commits intoethereum-optimism:developfrom
Closed
fix: Include Migrator address in ReadImplementationAddresses script output#189710xiamflux wants to merge 4 commits intoethereum-optimism:developfrom
ReadImplementationAddresses script output#189710xiamflux wants to merge 4 commits intoethereum-optimism:developfrom
Conversation
…819) * chore: return migrator address on ReadImplementationAddresses output * chore: use fixed solidity version * chore: just pr ready * test: add zero length code test for opcm
maurelian
reviewed
Jan 28, 2026
packages/contracts-bedrock/scripts/deploy/ReadImplementationAddresses.s.sol
Outdated
Show resolved
Hide resolved
Contributor
|
/ci authorize |
smartcontracts
approved these changes
Jan 30, 2026
Contributor
|
Approved. If the tests become difficult to maintain, we will deal with it. Given Claude exists, it should be fine. |
maurelian
approved these changes
Feb 2, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
… output (#18971) * chore: return migrator address on ReadImplementationAddresses output (#819) * chore: return migrator address on ReadImplementationAddresses output * chore: use fixed solidity version * chore: just pr ready * test: add zero length code test for opcm * chore: update tests on migrator (#822) * refactor: replace contract mocks with vm.mock * fix: read impl typo --------- Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently, when using OPCM v2 the
ReadImplementationAddressesscript output erroneously omits including the address of the migrator component of the OPCM v2. This PR fixes this by querying the address from the contracts manager and including it in the output.Changes
ReadImplementationAddressesoutputReadImplementationAddressesscript