Fix circular dependency issues in rollup-core#188
Merged
smartcontracts merged 2 commits intomasterfrom Jul 21, 2020
Merged
Conversation
rollup-core
willmeister
approved these changes
Jul 20, 2020
willmeister
left a comment
There was a problem hiding this comment.
Looks fine -- I might suggest leaving environment.ts in rollup-core though. That should just be reading env vars, and it's convenient to have all of those in one place. I could also be convinced to separate them by service, but I think we may have the same ones for a number of services, so consistency could be nice.
Contributor
Author
Sounds good. Will make that update in a sec. Edit: Pushed. |
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
Lredhdx
pushed a commit
to node-real/combo-optimism
that referenced
this pull request
Jun 17, 2024
…anet_info feat: update qanet config
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
Inphi
added a commit
that referenced
this pull request
Aug 16, 2024
* contracts: Add gas input to precompile pre-images (#186) Also update the cannon evm tests to use the new precompile preimage scheme. --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> * op-challenger: Support uploading data in new format. (#188) * op-program: Add required gas to precompile oracle key (#176) * op-challenger: Support multiple versions of the preimage oracle contract --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> --------- Co-authored-by: inphi <mlaw2501@gmail.com> --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Aug 20, 2024
…eum-optimism#252) * contracts: Add gas input to precompile pre-images (ethereum-optimism#186) Also update the cannon evm tests to use the new precompile preimage scheme. --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> * op-challenger: Support uploading data in new format. (ethereum-optimism#188) * op-program: Add required gas to precompile oracle key (ethereum-optimism#176) * op-challenger: Support multiple versions of the preimage oracle contract --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> --------- Co-authored-by: inphi <mlaw2501@gmail.com> --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
ajsutton
pushed a commit
that referenced
this pull request
Dec 10, 2024
* contracts: Add gas input to precompile pre-images (#186) Also update the cannon evm tests to use the new precompile preimage scheme. --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> * op-challenger: Support uploading data in new format. (#188) * op-program: Add required gas to precompile oracle key (#176) * op-challenger: Support multiple versions of the preimage oracle contract --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> --------- Co-authored-by: inphi <mlaw2501@gmail.com> --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> # Conflicts: # packages/contracts-bedrock/semver-lock.json # packages/contracts-bedrock/snapshots/state-diff/Kontrol-31337.json # packages/contracts-bedrock/src/cannon/PreimageOracle.sol # packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummary.sol # packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryCode.sol # packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryFaultProofs.sol # packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryFaultProofsCode.sol
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](op-rs/kona#695). This PR introduces the `SingleBatch` type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rollup-corecurrently depends onrollup-contractsfor various L1/L2 node initialization tasks.rollup-coreis used within many other packages, meaning we end up with circular dependency errors withinrollup-contracts. This PR shifts these dependencies intorollup-full-node, the only package actually making use of the offending functions (will not be a dependency ofrollup-contracts)Metadata
Fixes
Contributing Agreement