proposal/op contracts/v5.0.0 rc.1+l2 fee splitter contracts#18474
Merged
maurelian merged 9 commits intoethereum-optimism:proposal/op-contracts/v5.0.0from Dec 9, 2025
Conversation
* feat: fee splitter system (#469) ---- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: failing tests (#553) * refactor: revenue sharing config (#538) * fix: pre pr and semgrep (#565) * fix: warnings (#571) * fix: tests failing on fork environment (#575) * fix: use encode call on constructors (#578) * feat: add integration splitter test (#581) * fix: integration test nits (#583) * test: more coverage on splitter tests (#594) --------- Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: add missing operator fee vault field (#616) * feat: invariants and tests (#595) * fix: ir informationals (#609) * fix: pre pr (#622) * refactor: use cdm (#624) * fix: update withdrawal gas limit value on check (#627) * fix: remove rev share field from deploy op chain input struct (#628) * refactor: remove initializer and vaults getter changes (#631) * fix: remove immutable check over vaults (#634) Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com> * fix: audit findings (#658) * fix: pre pr * feat: add user guide docs for rev sharing on op deployer (#666) * docs: add create2 comment (#667) --------- Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com> Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>
* Add DeployFeesDepositor script * Refactor deploy script to remove Output struct * forge fmt * Make logResults() pure * fix return value names * remove unused import * Apply suggestions from code review Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> * Add missing natspec * Add natspec to tests --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
maurelian
requested changes
Dec 3, 2025
Contributor
maurelian
left a comment
There was a problem hiding this comment.
One change is requested to the audits readme.
Otherwise this LGTM. For the review I compared this branch to the commit listed as final in the audit report (f1fcd96), to ensure that the src/L2 contracts had no diff.
I also verified that the diff applied here contains only changes relevant to the rev share contracts.
Contributor
Author
|
/ci authorize 3040c54 |
maurelian
approved these changes
Dec 3, 2025
smartcontracts
approved these changes
Dec 5, 2025
Contributor
|
/ci authorize 3040c54 |
1 similar comment
Contributor
Author
|
/ci authorize 3040c54 |
0a1a5e0
into
ethereum-optimism:proposal/op-contracts/v5.0.0
70 checks passed
This was referenced Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding only revenue sharing project related changes for the
v5.0.0-rc.1+l2-fee-splitter-contractsrelease