Skip to content

feat: clean up deployment artifacts#1768

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/clean-deploy-artifacts
Nov 22, 2021
Merged

feat: clean up deployment artifacts#1768
smartcontracts merged 1 commit intodevelopfrom
sc/clean-deploy-artifacts

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented Nov 14, 2021 •
edited
Loading

Description
Various deployment artifact cleanups:

  1. Removed mainnet-trial and mainnet-trial-2 artifacts.
  2. Rewrote generate-markdown in TypeScript.
  3. Modified generate-markdown so that it generates READMEs for each deployment instead of generating one massive README.
  4. Added AddressDictator and ChugSplashDictator to the list of hidden addresses.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 14, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: f832247

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smartcontracts smartcontracts marked this pull request as draft November 14, 2021 17:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 14, 2021 •
edited
Loading

Codecov Report

Merging #1768 (e923ce8) into develop (b882d8c) will not change coverage.
The diff coverage is n/a.

❗ Current head e923ce8 differs from pull request most recent head 87a5bd2. Consider uploading reports for the commit 87a5bd2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1768   +/-   ##
========================================
  Coverage    71.81%   71.81%           
========================================
  Files           69       69           
  Lines         2303     2303           
  Branches       344      344           
========================================
  Hits          1654     1654           
  Misses         649      649
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b882d8c...87a5bd2. Read the comment docs.

@smartcontracts smartcontracts force-pushed the sc/clean-deploy-artifacts branch 3 times, most recently from eac8ffd to d899cbc Compare November 15, 2021 06:07
@smartcontracts smartcontracts marked this pull request as ready for review November 15, 2021 15:07
maurelian
maurelian requested changes Nov 16, 2021
View reviewed changes
@smartcontracts smartcontracts force-pushed the sc/clean-deploy-artifacts branch from e923ce8 to 87a5bd2 Compare November 17, 2021 06:23
@smartcontracts smartcontracts requested a review from tynes November 17, 2021 16:27
@maurelian maurelian self-requested a review November 17, 2021 16:28
maurelian
maurelian approved these changes Nov 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smartcontracts smartcontracts force-pushed the sc/clean-deploy-artifacts branch from 87a5bd2 to f832247 Compare November 22, 2021 20:15
annieke
annieke approved these changes Nov 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@annieke annieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the new deployment md files and they look good, generate-markdown.ts is also v easy to read so lgtm!

packages/contracts/scripts/generate-markdown.ts
Comment on lines +96 to +98
// We use HTML instead of markdown so we can get a table that displays well on GitHub.
// GitHub READMEs are 1012px wide. Adding a 506px image to each table header is a hack that
// allows us to create a table where each column is 1/2 the full README width.
Copy link
Copy Markdown
Contributor

@annieke annieke Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@smartcontracts smartcontracts merged commit 5ed7f75 into develop Nov 22, 2021
@smartcontracts smartcontracts deleted the sc/clean-deploy-artifacts branch November 22, 2021 22:18
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
fix(p2p): Discv5 startup panic (#1768)
a70c0a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maurelian maurelian maurelian approved these changes

@tynes tynes Awaiting requested review from tynes

+1 more reviewer

@annieke annieke annieke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smartcontracts @codecov-commenter @annieke @maurelian