Merged
Conversation
…s from getTransaction and getBlock requests and adding test
…s from getTransaction and getBlock requests and adding test
… other future scheduled tasks)
…ckBatchSubmitter into L2NodeService
karlfloersch
approved these changes
Jul 6, 2020
Contributor
There was a problem hiding this comment.
Awesome! This LGTM! And it seems very clean as well! Great separation between batch creation, submission, and pulling data from L1/L2 into rdb!
Left a comment on blockBatches vs blockOfBatches lol forgive me but other than that I didn't have much to say. Oh and there's a sanity check test that could be added as well
| * @inheritDoc | ||
| */ | ||
| public async handleBlockBatches(blockBatches: BlockBatches): Promise<void> { | ||
| public async sendBlockBatches(blockBatches: BlockBatches): Promise<void> { |
Contributor
There was a problem hiding this comment.
I really have struggled to find things to complain about in this PR! Lol everything seems good! That said, I will say that I still do like the name BlockOfBatches here because once again I had to remind myself what this object was
Contributor
There was a problem hiding this comment.
I know we said we'd update it later but figure that because this PR touches them again might be a reasonable time to make the change if it's not super hard?
Author
There was a problem hiding this comment.
Yeah, I think a rename is in order since we will no longer be sending all batches for an L1 block together, and each one will be a single batch. This requires a change on the go side as well, so just left it for now.
Author
There was a problem hiding this comment.
Created a ticket https://optimists.atlassian.net/browse/YAS-499
| `1 L1 matching batche should have been attempted!` | ||
| ) | ||
| }) | ||
| }) |
Contributor
There was a problem hiding this comment.
👍 solid! I guess one thing we could add is a test that actually does produce a batch
Author
There was a problem hiding this comment.
Yep! That'll have to be on the submission side of things though, as all this does is stage the batch for submission in the DB.
| l1Timestamp: 1, | ||
| l1BlockNumber: 1, | ||
| l1TxHash: keccak256FromUtf8('tx hash'), | ||
| queueOrigin: 1, |
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* Add nonreentrant to ExecutionManager.run() * Cheaper check using uninit'd tx context * Remove extraneous import
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Dec 9, 2024
c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Apr 4, 2025
c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Apr 7, 2025
c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
blockchaindevsh
added a commit
to blockchaindevsh/optimism
that referenced
this pull request
Jun 30, 2025
* binary release for op-node * add a comment * add workflow for op-challenger
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds L2 Batch Creator that creates batches from txs run in L2.
Note: This is distinct from L1 Batch Creator, which will create batches out of Rollup Transactions pulled from L1 tx calldata.
Metadata
Fixes
Contributing Agreement