Skip to content

test: add erc20 test coverage#1745

Merged
tynes merged 1 commit intodevelopfrom
fix/erc20-surgery-tests
Nov 19, 2021
Merged

test: add erc20 test coverage#1745
tynes merged 1 commit intodevelopfrom
fix/erc20-surgery-tests

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Nov 10, 2021

Description
Adds tests for erc20 state diffs. Additional special cases need to be added to handle certain contracts that should have a diff. These contracts are:

0x6fd9d7ad17242c41f7131d257212c54a0e816691
0x7fb688ccf682d58f86d7e38e03f9d22e7705448b
0xb27e3eab7526bf721ea8029bfcd3fdc94c4f8b5b
0x8f69ee043d52161fd29137aedf63f5e70cd504d5
0x7c17611ed67d562d1f00ce82eebd39cb7b595472
0x4200000000000000000000000000000000000006
0xe3c332a5dce0e1d9bc2cc72a68437790570c28a4
0x94b008aa00579c1307b0ef2c499ad98a8ce58e58
0x68f180fcce6836688e9084f035309e29bf0a2095
0xda10009cbd5d07dd0cecc66161fc93d7c9000da1
0xab7badef82e9fe11f6f33f87bc9bc2aa27f2fcb5
0x350a791bfc2c21f9ed5d10980dad2e2638ffa7f6
0xe0bb0d3de8c10976511e5030ca403dbf4c25165b
0x96db852d93c2fea0f447d6ec22e146e4e09caee6
0x7f5c764cbc14f9669b88837ca1490cca17c31607
0xb548f63d4405466b36c0c0ac3318a22fdcec711a

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 10, 2021

⚠️ No Changeset found

Latest commit: 561161a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #1745 (561161a) into develop (87c4dc7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1745   +/-   ##
========================================
  Coverage    71.81%   71.81%           
========================================
  Files           69       69           
  Lines         2303     2303           
  Branches       344      344           
========================================
  Hits          1654     1654           
  Misses         649      649
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c4dc7...561161a. Read the comment docs.

@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Nov 12, 2021

The additional changes that I have for this PR involve mostly logging. Happy to push them but I don't think they add a ton of value. I think this PR is ok to merge as is

@tynes tynes merged commit dc1eb77 into develop Nov 19, 2021
@tynes tynes deleted the fix/erc20-surgery-tests branch November 19, 2021 21:25
theochap pushed a commit that referenced this pull request Dec 10, 2025
@varun-doshi
chore: dedup GlobalArgs for log verbosity (#2066)
723a78f 
Closes #1745
theochap pushed a commit that referenced this pull request Jan 14, 2026
@varun-doshi
chore: dedup GlobalArgs for log verbosity (op-rs/kona#2066)
70c7082 
Closes #1745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tynes @codecov-commenter