Skip to content

regenesis-surgery: predeploy tests#1725

Merged
tynes merged 2 commits intodevelopfrom
test/predeploys
Nov 19, 2021
Merged

regenesis-surgery: predeploy tests#1725
tynes merged 2 commits intodevelopfrom
test/predeploys

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Nov 9, 2021 •
edited
Loading

Description

Adds test coverage of the predeploys in the regenesis-surgery package

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 9, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d5226e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 9, 2021 •
edited
Loading

Codecov Report

Merging #1725 (d5226e8) into develop (12b153a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1725   +/-   ##
========================================
  Coverage    71.81%   71.81%           
========================================
  Files           69       69           
  Lines         2303     2303           
  Branches       344      344           
========================================
  Hits          1654     1654           
  Misses         649      649
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b153a...d5226e8. Read the comment docs.

Base automatically changed from regenesis/0.5.0 to develop November 10, 2021 22:08
@github-actions github-actions bot added 2-reviewers A-op-batcher Area: op-batcher M-ci Meta: ci related work A-pkg-core-utils Area: packages/core-utils A-integration Area: integration tests A-cannon Area: cannon A-ops Area: ops labels Nov 12, 2021
tynes and others added 2 commits November 12, 2021 10:04
@github-actions github-actions bot removed M-contracts A-integration Area: integration tests M-ci Meta: ci related work A-cannon Area: cannon A-op-batcher Area: op-batcher A-pkg-core-utils Area: packages/core-utils A-ops Area: ops labels Nov 12, 2021
@tynes tynes changed the title regenesis-surgery: initial predeploy spec regenesis-surgery: predeploy tests Nov 12, 2021
@tynes tynes requested a review from annieke November 12, 2021 18:35
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Nov 12, 2021

This generally looks good to me

annieke
annieke reviewed Nov 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@annieke annieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tynes i think this needs a rebase and amended second commit?

@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Nov 13, 2021

@tynes i think this needs a rebase and amended second commit?

This PR should have the 2 commits we want and is rebased

@tynes tynes merged commit 3f4bf7a into develop Nov 19, 2021
@tynes tynes deleted the test/predeploys branch November 19, 2021 21:25
theochap pushed a commit that referenced this pull request Dec 10, 2025
@itschaindev
feat(supervisor/rpc): implement supervisor_finalizedL1 (#2157)
096c2f6 
Closes #1725
theochap pushed a commit that referenced this pull request Jan 14, 2026
@itschaindev
feat(supervisor/rpc): implement supervisor_finalizedL1 (op-rs/kona#…
5e6b346 
…2157)

Closes #1725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@annieke annieke annieke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @codecov-commenter @annieke