Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16941 +/- ##
===========================================
- Coverage 45.50% 44.60% -0.91%
===========================================
Files 1459 1405 -54
Lines 119013 114347 -4666
===========================================
- Hits 54160 50999 -3161
+ Misses 61050 59693 -1357
+ Partials 3803 3655 -148
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
077211d to
b368a46
Compare
b368a46 to
d1c9f2a
Compare
nonsense
reviewed
Aug 11, 2025
nonsense
approved these changes
Aug 11, 2025
teddyknox
approved these changes
Aug 11, 2025
d1c9f2a to
98583d1
Compare
theochap
pushed a commit
to theochap/optimism
that referenced
this pull request
Aug 26, 2025
…Unsafe (ethereum-optimism#16941) * Add mock engDeriver * Embed engDeriver to attributesHandler * Fix tests * Fix test * Explicit init of engDeriver for attributesHandler * add comment * Rm PromoteUnsafeEvent * Make the payload success flow sequential * rm unused * temporal commit to make test pass * wait try engine update event * More explanatory comment * Move interfaces nearby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
PromoteUnsafeEvent,PromotePendingSafeEvent,PromoteLocalSafeEventto a procedural call.Key Changes
Now AttributeHandler embeds EngDeriver. AttributeHandler directly invokes methods of EngDeriver in this PR.
Notes
Inside
onPayloadSuccesswhich is emitted by sequencer, we originally had four event emissions in the happy path.PromoteUnsafeEvent -> TryUpdatePendingSafe -> TryUpdateLocalSafe -> TryUpdateEngineEvent. I initially only picked two eventsTryUpdatePendingSafeandTryUpdateLocalSafeand took quite a time what was wrong. What happened was two events exec order were mixed with procedural calls, leading to test failure.For further refactoring, we may be aware of this observations and make sure to convert the sequential events in a sequential procedural method call.
Tests
All existing tests are passing.
There are changes at
TestSpanBatchAtomicity_Consolidationatsync_test.go. The point of the test is to check the safe head is bumped after we consolidated the whole span batch. This is done whenPromoteSafeEventis consumed andTryUpdateEngineEventis emitted. Changed the condition since the test were failing, and did not find out exactly why the test was failing.