Skip to content

[Issue-1682] Cleanup unused imports#1684

Merged
smartcontracts merged 1 commit intoethereum-optimism:regenesis/0.5.0from
coreyar:issue-1682-cleanup-unused-imports
Nov 4, 2021
Merged

[Issue-1682] Cleanup unused imports#1684
smartcontracts merged 1 commit intoethereum-optimism:regenesis/0.5.0from
coreyar:issue-1682-cleanup-unused-imports

Conversation

@coreyar
Copy link
Copy Markdown
Contributor

@coreyar coreyar commented Nov 3, 2021

Description
Adds eslint rule to error on unused vars. This PR also fixes violations of that rule not only in the integration tests but in the whole project

Additional context

Metadata

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 3, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: c9a783e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-pkg-core-utils Area: packages/core-utils A-integration Area: integration tests labels Nov 3, 2021
smartcontracts
smartcontracts approved these changes Nov 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, thank you!

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 3, 2021

Looks like the linting is failing, there are more unused imports

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #1684 (4fb310b) into regenesis/0.5.0 (8f21774) will increase coverage by 3.00%.
The diff coverage is 100.00%.

❗ Current head 4fb310b differs from pull request most recent head c9a783e. Consider uploading reports for the commit c9a783e to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                 @@
##           regenesis/0.5.0    #1684      +/-   ##
===================================================
+ Coverage            72.72%   75.72%   +3.00%     
===================================================
  Files                   69       56      -13     
  Lines                 2273     1961     -312     
  Branches               336      289      -47     
===================================================
- Hits                  1653     1485     -168     
+ Misses                 620      476     -144
Flag Coverage Δ
batch-submitter 61.33% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 58.40% <100.00%> (-0.13%) ⬇️
data-transport-layer ?
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-utils/src/watcher.ts 6.06% <ø> (-1.41%) ⬇️
packages/core-utils/src/common/misc.ts 46.66% <100.00%> (ø)
...ices/l1-ingestion/handlers/transaction-enqueued.ts
packages/data-transport-layer/src/utils/index.ts
...ckages/data-transport-layer/src/utils/contracts.ts
packages/message-relayer/hardhat.config.ts
.../src/services/l2-ingestion/handlers/transaction.ts
...ices/l1-ingestion/handlers/state-batch-appended.ts
...layer/src/services/l1-ingestion/handlers/errors.ts
.../l1-ingestion/handlers/sequencer-batch-appended.ts
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f21774...c9a783e. Read the comment docs.

@coreyar
Copy link
Copy Markdown
Contributor Author

coreyar commented Nov 3, 2021

Looks like the linting is failing, there are more unused imports

Hmm ok let me check

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 3, 2021

Happy to merge once the additional linting errors are fixed. You can see them on github if you look at the files changed

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 4, 2021

Looks like there is now a merge conflict - do you mind rebasing to fix the conflict and then squashing all of the commits into a single commit?

@coreyar
Copy link
Copy Markdown
Contributor Author

coreyar commented Nov 4, 2021

Looks like there is now a merge conflict - do you mind rebasing to fix the conflict and then squashing all of the commits into a single commit?

Ahh I just saw this. Yes I can take care of this

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 4, 2021

Please squash your commits into a single commit and this will be good to merge

@coreyar coreyar force-pushed the issue-1682-cleanup-unused-imports branch from c69d566 to 7e32d2d Compare November 4, 2021 12:56
@coreyar coreyar closed this Nov 4, 2021
@coreyar coreyar force-pushed the issue-1682-cleanup-unused-imports branch from 7e32d2d to 2144736 Compare November 4, 2021 12:58
@github-actions github-actions bot removed A-integration Area: integration tests A-pkg-core-utils Area: packages/core-utils M-contracts labels Nov 4, 2021
@coreyar coreyar reopened this Nov 4, 2021
@github-actions github-actions bot added 2-reviewers A-pkg-core-utils Area: packages/core-utils A-integration Area: integration tests labels Nov 4, 2021
@coreyar coreyar force-pushed the issue-1682-cleanup-unused-imports branch from e64386a to 4fb310b Compare November 4, 2021 13:04
@coreyar coreyar force-pushed the issue-1682-cleanup-unused-imports branch from 4fb310b to c9a783e Compare November 4, 2021 16:25
@smartcontracts smartcontracts merged commit 1dd1022 into ethereum-optimism:regenesis/0.5.0 Nov 4, 2021
@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented Nov 4, 2021

Great work @coreyar, thank you!

theochap pushed a commit that referenced this pull request Dec 10, 2025
@sadiq1971 @dhyaniarun1993 @emhane
feat(supervisor/db): safety head reference storage (#1865)
bf214d0 
Closes #1750, #1684, #1871

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
theochap pushed a commit that referenced this pull request Jan 14, 2026
@sadiq1971 @dhyaniarun1993 @emhane
feat(supervisor/db): safety head reference storage (op-rs/kona#1865)
436e17f 
Closes #1750, #1684, #1871

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

A-integration Area: integration tests A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coreyar @tynes @codecov-commenter @smartcontracts