Skip to content

Bypass lua checking when the request is not a POST#1647

Merged
tynes merged 2 commits intodevelopfrom
bwilson/rpc-proxy-only-on-post
Oct 29, 2021
Merged

Bypass lua checking when the request is not a POST#1647
tynes merged 2 commits intodevelopfrom
bwilson/rpc-proxy-only-on-post

Conversation

@optimisticben
Copy link
Copy Markdown
Contributor

@optimisticben optimisticben commented Oct 28, 2021

Description
We should only validate POST http methods.

This update will allow OPTIONS to pass though to the l2geth backend.

Fixes ENG-1589

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 28, 2021

🦋 Changeset detected

Latest commit: 3e09aa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/rpc-proxy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@optimisticben optimisticben marked this pull request as ready for review October 29, 2021 14:11
Fixed nit, added changeset for rpc-proxy
@optimisticben optimisticben force-pushed the bwilson/rpc-proxy-only-on-post branch from fa22b50 to f7c7849 Compare October 29, 2021 14:14
@optimisticben optimisticben requested a review from tynes October 29, 2021 14:14
@github-actions github-actions bot added the M-ci Meta: ci related work label Oct 29, 2021
@tynes tynes merged commit 240e62e into develop Oct 29, 2021
@tynes tynes deleted the bwilson/rpc-proxy-only-on-post branch October 29, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants